Skip to content
Permalink
Browse files

Update pull request template and contribute.md

  • Loading branch information
m-kuhn committed Mar 12, 2017
1 parent 1d52846 commit cd7b19c371fc0078541491ca78d96bb107f3e2ee
Showing with 10 additions and 13 deletions.
  1. +1 −1 { → .github}/CONTRIBUTE.md
  2. +9 −12 .github/PULL_REQUEST_TEMPLATE.md
@@ -21,5 +21,5 @@ Getting your pull request merged
This is a volunteer project, so sometimes it may take a little while to merge
your pull request.

There is a [guide with hints for getting your pull requests merged](https://github.com/m-kuhn/QGIS-Website/blob/qtcreator.rst/source/site/getinvolved/development/git.rst#pull-requests)
There is a [guide with hints for getting your pull requests merged](https://www.qgis.org/en/site/getinvolved/development/qgisdevelopersguide/git.html#pull-requests)

This comment has been minimized.

Copy link
@DelazJ

DelazJ Mar 12, 2017

Contributor

@m-kuhn better use links fromthe Devs doc at http://docs.qgis.org/testing/en/docs/developers_guide/index.html
when 2.8 is released, we'll remove the chapter from qgis.org

This comment has been minimized.

Copy link
@m-kuhn

m-kuhn Mar 12, 2017

Author Member

Sure, could you make a pull request (I guess you are faster than me to find the proper location :) )

in the developers guide.
@@ -1,18 +1,15 @@
## Description
Include a few sentences describing the overall goals for this pull request.
Include a few sentences describing the overall goals for this PR (pull request). If applicable also add screenshots.

## Checklist

All checklist items should be addressed before a QGIS maintainer will review the request:
> Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.
- [ ] I've read the [QGIS Coding Standards](https://www.qgis.org/en/site/getinvolved/development/qgisdevelopersguide/codingstandards.html) and this PR complies with them
- [ ] This PR passes all existing unit tests
- [ ] New unit tests have been added for core changes
- [ ] I've run the scripts/prepare-commit.sh script before each commit
- [ ] Commit messages are descriptive and explain the rationale for changes
- [ ] Commits which fix bugs include "fixes #11111" in the commit message
- [ ] Commits which add new features are tagged with \[FEATURE\] in the commit message
- [ ] Commits which change the UI or existing user workflows are tagged with \[needs-docs\] in the commit message



- [ ] Commits which fix bugs include `fixes #11111` in the commit message next to the description
- [ ] Commits which add new features are tagged with `[FEATURE]` in the commit message
- [ ] Commits which change the UI or existing user workflows are tagged with `[needs-docs]` in the commit message and containt sufficient information in the commit message to be documented
- [ ] I have read the [QGIS Coding Standards](https://www.qgis.org/en/site/getinvolved/development/qgisdevelopersguide/codingstandards.html) and this PR complies with them

This comment has been minimized.

Copy link
@DelazJ

DelazJ Mar 12, 2017

Contributor

same

- [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
- [ ] New unit tests have been added for core changes
- [ ] I have run [the `scripts/prepare-commit.sh` script](https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTE.md#contributing-to-qgis) before each commit

0 comments on commit cd7b19c

Please sign in to comment.
You can’t perform that action at this time.