Skip to content

Commit cda4df4

Browse files
author
Sandro Santilli
committed
Handle save and load error for rendered image
1 parent 5357263 commit cda4df4

File tree

1 file changed

+18
-1
lines changed

1 file changed

+18
-1
lines changed

src/core/qgsrenderchecker.cpp

+18-1
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,15 @@ bool QgsRenderChecker::runTest( QString theTestName,
214214

215215
myImage.setDotsPerMeterX( myExpectedImage.dotsPerMeterX() );
216216
myImage.setDotsPerMeterY( myExpectedImage.dotsPerMeterY() );
217-
myImage.save( mRenderedImageFile, "PNG", 100 );
217+
if ( ! myImage.save( mRenderedImageFile, "PNG", 100 ) )
218+
{
219+
qDebug() << "QgsRenderChecker::runTest failed - Could not save rendered image to " << mRenderedImageFile;
220+
mReport = "<table>"
221+
"<tr><td>Test Result:</td><td>Expected Result:</td></tr>\n"
222+
"<tr><td>Nothing rendered</td>\n<td>Failed because Rendered "
223+
"Image File could not be saved.</td></tr></table>\n";
224+
return false;
225+
}
218226

219227
//create a world file to go with the image...
220228

@@ -266,6 +274,15 @@ bool QgsRenderChecker::compareImages( QString theTestName,
266274
//
267275
QImage myExpectedImage( mExpectedImageFile );
268276
QImage myResultImage( mRenderedImageFile );
277+
if ( myResultImage.isNull() )
278+
{
279+
qDebug() << "QgsRenderChecker::runTest failed - Could not load rendered image from " << mRenderedImageFile;
280+
mReport = "<table>"
281+
"<tr><td>Test Result:</td><td>Expected Result:</td></tr>\n"
282+
"<tr><td>Nothing rendered</td>\n<td>Failed because Rendered "
283+
"Image File could not be loaded.</td></tr></table>\n";
284+
return false;
285+
}
269286
QImage myDifferenceImage( myExpectedImage.width(),
270287
myExpectedImage.height(),
271288
QImage::Format_RGB32 );

0 commit comments

Comments
 (0)