ogr: don't create spatial index for shapes after deletes. That was supposed to

jef-n · jef-n · commit cf7e016be9fe · 2014-06-13T22:54:04.000+02:00
also run a repack and doesn't work without (fixes #10483, refs #8317, refs #8822)
diff --git a/src/core/qgsvectorlayereditbuffer.cpp b/src/core/qgsvectorlayereditbuffer.cpp
@@ -245,8 +245,6 @@ bool QgsVectorLayerEditBuffer::commitChanges( QStringList& commitErrors )
 
   QgsFields oldFields = L->pendingFields();
 
-  bool hadPendingDeletes = !mDeletedFeatureIds.isEmpty();
-
   //
   // delete attributes
   //
@@ -504,13 +502,6 @@ bool QgsVectorLayerEditBuffer::commitChanges( QStringList& commitErrors )
     }
   }
 
-  // for shapes run a REPACK after each transaction
-  // TODO: enhance provider interface to allow moving this there
-  if ( success && hadPendingDeletes && L->providerType() == "ogr" && L->storageType() == "ESRI Shapefile" )
-  {
-    provider->createSpatialIndex();
-  }
-
   if ( !success && provider->hasErrors() )
   {
     commitErrors << tr( "\n  Provider errors:" );

Original file line number	Diff line number	Diff line change
`@@ -245,8 +245,6 @@ bool QgsVectorLayerEditBuffer::commitChanges( QStringList& commitErrors )`
`245`	`245`
`246`	`246`	`QgsFields oldFields = L->pendingFields();`
`247`	`247`
`248`		`- bool hadPendingDeletes = !mDeletedFeatureIds.isEmpty();`
`249`		`-`
`250`	`248`	`//`
`251`	`249`	`// delete attributes`
`252`	`250`	`//`
`@@ -504,13 +502,6 @@ bool QgsVectorLayerEditBuffer::commitChanges( QStringList& commitErrors )`
`504`	`502`	`}`
`505`	`503`	`}`
`506`	`504`
`507`		`- // for shapes run a REPACK after each transaction`
`508`		`- // TODO: enhance provider interface to allow moving this there`
`509`		`- if ( success && hadPendingDeletes && L->providerType() == "ogr" && L->storageType() == "ESRI Shapefile" )`
`510`		`- {`
`511`		`- provider->createSpatialIndex();`
`512`		`- }`
`513`		`-`
`514`	`505`	`if ( !success && provider->hasErrors() )`
`515`	`506`	`{`
`516`	`507`	`commitErrors << tr( "\n Provider errors:" );`