-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[db_manager] Fix DBConnector.getSchemaTableName
Fix #15910
- Loading branch information
1 parent
09d1263
commit cfe8dfe
Showing
1 changed file
with
3 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfe8dfe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first conditional seems wrong (not hasattrs and not isinstance...) because a
str
instance would not have__iter__
attribute, so the check is superflous, right ?cfe8dfe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a test for the case table parameter is "schemaname.tablename", this have caused db_manage to be unusable for a long time.
cfe8dfe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, Missunderstood your comment, the first test seems to be for the case table parameter is not an instance of str (something else, like a TableDataModel or TableItem). Having a more explicit test would be better here.