Apply FilterRect in combination with other filters

qgis · Jul 29, 2015 · cfe91f8 · cfe91f8
1 parent b47b9a5
commit cfe91f8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/core/qgsfeaturerequest.cpp b/src/core/qgsfeaturerequest.cpp
@@ -87,7 +87,6 @@ QgsFeatureRequest::~QgsFeatureRequest()
 
 QgsFeatureRequest& QgsFeatureRequest::setFilterRect( const QgsRectangle& rect )
 {
-  mFilter = FilterRect;
   mFilterRect = rect;
   return *this;
 }

diff --git a/src/core/qgsfeaturerequest.h b/src/core/qgsfeaturerequest.h
@@ -70,7 +70,7 @@ class CORE_EXPORT QgsFeatureRequest
     enum FilterType
     {
       FilterNone,       //!< No filter is applied
-      FilterRect,       //!< Filter using a rectangle, no need to set NoGeometry
+      FilterRect,       //!< Obsolete, will be ignored. If a filterRect is set it will be used anyway. Filter using a rectangle, no need to set NoGeometry. Instead check for request.filterRect().isNull()
       FilterFid,        //!< Filter using feature ID
       FilterExpression, //!< Filter using expression
       FilterFids        //!< Filter using feature IDs
@@ -93,7 +93,7 @@ class CORE_EXPORT QgsFeatureRequest
 
     ~QgsFeatureRequest();
 
-    FilterType filterType() const { return mFilter; }
+    FilterType filterType() const { if ( mFilter == FilterNone && !mFilterRect.isNull() ) return FilterRect; else return mFilter; }
 
     //! Set rectangle from which features will be taken. Empty rectangle removes the filter.
     //!