[Plugin manager] [needs-doc] Don't preload plugins for a test if they are broken. That function slowed down QGIS startup

Author: borysiasty

python/pyplugin_installer/installer.py

@@ -307,7 +307,7 @@ def installPlugin(self, key, quiet=False):
             updateAvailablePlugins()
             # try to load the plugin
             loadPlugin(plugin["id"])
-            plugins.getAllInstalled(testLoad=True)
+            plugins.getAllInstalled()
             plugins.rebuild()
             plugin = plugins.all()[key]
             if not plugin["error"]:
@@ -565,7 +565,7 @@ def installFromZipFile(self, filePath):
         if infoString is None:
             updateAvailablePlugins()
             loadPlugin(pluginName)
-            plugins.getAllInstalled(testLoad=True)
+            plugins.getAllInstalled()
             plugins.rebuild()
 
             if settings.contains('/PythonPlugins/' + pluginName):

python/pyplugin_installer/installer_data.py

@@ -548,7 +548,7 @@ def removeRepository(self, repo):
             del self.repoCache[repo]
 
     # ----------------------------------------- #
-    def getInstalledPlugin(self, key, path, readOnly, testLoad=True):
+    def getInstalledPlugin(self, key, path, readOnly, testLoad=False):
         """ get the metadata of an installed plugin """
         def metadataParser(fct):
             """ plugin metadata parser reimplemented from qgis.utils
@@ -683,8 +683,11 @@ def pluginMetadata(fct):
         return plugin
 
     # ----------------------------------------- #
-    def getAllInstalled(self, testLoad=True):
-        """ Build the localCache """
+    def getAllInstalled(self, testLoad=False):
+        """ Build the localCache
+            Note: Currently testLoad is always disabled in order to speed up QGIS startup.
+                  The related code will be probably removed.
+        """
         self.localCache = {}
 
         # reversed list of the plugin paths: first system plugins -> then user plugins -> finally custom path(s)