Skip to content

Commit

Permalink
[FEATURE][processing] Remove duplicate fill holes algorithm
Browse files Browse the repository at this point in the history
The Fill_holes script is duplicated by the DeleteHoles algorithm,
and the DeleteHoles algorithm has many advantages:
- it's a full algorithm rather than a script
- uses qgis geometry classes and maintains curves/z/m
- has unit tests
- doesn't rely on non-standard external library (shapely)

(marked as feature for inclusion in release notes)
  • Loading branch information
nyalldawson committed Nov 29, 2016
1 parent 45a52df commit d4c38f9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 45 deletions.
2 changes: 1 addition & 1 deletion python/plugins/processing/algs/qgis/DeleteHoles.py
Expand Up @@ -41,7 +41,7 @@ class DeleteHoles(GeoAlgorithm):
def defineCharacteristics(self):
self.name, self.i18n_name = self.trAlgorithm('Delete holes')
self.group, self.i18n_group = self.trAlgorithm('Vector geometry tools')
self.tags = self.tr('remove,delete,drop,holes,rings')
self.tags = self.tr('remove,delete,drop,holes,rings,fill')

self.addParameter(ParameterVector(self.INPUT,
self.tr('Input layer'), [dataobjects.TYPE_VECTOR_POLYGON]))
Expand Down
44 changes: 0 additions & 44 deletions python/plugins/processing/algs/qgis/scripts/Fill_holes.py

This file was deleted.

0 comments on commit d4c38f9

Please sign in to comment.