Fix form constraints and group visibility

m-kuhn · m-kuhn · commit d5d3eeee35a7 · 2016-10-21T11:02:39.000+02:00
When a relation editor was shown (or more generally a widget which is not an
editor widget), constraints and group visibility were silently disabled.
diff --git a/src/gui/qgsattributeform.cpp b/src/gui/qgsattributeform.cpp
@@ -754,7 +754,11 @@ bool QgsAttributeForm::currentFormFeature( QgsFeature &feature )
   Q_FOREACH ( QgsWidgetWrapper* ww, mWidgets )
   {
     QgsEditorWidgetWrapper* eww = qobject_cast<QgsEditorWidgetWrapper*>( ww );
-    if ( eww && dst.count() > eww->fieldIdx() )
+
+    if ( !eww )
+      continue;
+
+    if ( dst.count() > eww->fieldIdx() )
     {
       QVariant dstVar = dst.at( eww->fieldIdx() );
       QVariant srcVar = eww->value();

Original file line number	Diff line number	Diff line change
`@@ -754,7 +754,11 @@ bool QgsAttributeForm::currentFormFeature( QgsFeature &feature )`
`754`	`754`	`Q_FOREACH ( QgsWidgetWrapper* ww, mWidgets )`
`755`	`755`	`{`
`756`	`756`	`QgsEditorWidgetWrapper* eww = qobject_cast<QgsEditorWidgetWrapper*>( ww );`
`757`		`- if ( eww && dst.count() > eww->fieldIdx() )`
	`757`	`+`
	`758`	`+ if ( !eww )`
	`759`	`+ continue;`
	`760`	`+`
	`761`	`+ if ( dst.count() > eww->fieldIdx() )`
`758`	`762`	`{`
`759`	`763`	`QVariant dstVar = dst.at( eww->fieldIdx() );`
`760`	`764`	`QVariant srcVar = eww->value();`