Use QgsLayerStyleOverride in QgsMapHitTest::runHitTestLayer

qgis · Jun 11, 2018 · d62c34af0e27edc41495028906d8ec1bad840704 · d62c34a
1 parent 5c267f2
commit d62c34af0e27edc41495028906d8ec1bad840704
Unified Split

Showing with 3 additions and 6 deletions.

+3 −6 src/core/qgsmaphittest.cpp
diff --git a/src/core/qgsmaphittest.cpp b/src/core/qgsmaphittest.cpp
@@ -101,9 +101,9 @@ bool QgsMapHitTest::legendKeyVisible( const QString &ruleKey, QgsVectorLayer *la
 
 void QgsMapHitTest::runHitTestLayer( QgsVectorLayer *vl, SymbolSet &usedSymbols, SymbolSet &usedSymbolsRuleKey, QgsRenderContext &context )
 {
-  bool hasStyleOverride = mSettings.layerStyleOverrides().contains( vl->id() );
-  if ( hasStyleOverride )
-    vl->styleManager()->setOverrideStyle( mSettings.layerStyleOverrides().value( vl->id() ) );
+  QgsLayerStyleOverride styleOverride( vl );
+  if ( mSettings.layerStyleOverrides().contains( vl->id() ) )
+    styleOverride.setOverrideStyle( mSettings.layerStyleOverrides().value( vl->id() ) );
 
   std::unique_ptr< QgsFeatureRenderer > r( vl->renderer()->clone() );
   bool moreSymbolsPerFeature = r->capabilities() & QgsFeatureRenderer::MoreSymbolsPerFeature;
@@ -199,8 +199,5 @@ void QgsMapHitTest::runHitTestLayer( QgsVectorLayer *vl, SymbolSet &usedSymbols,
     usedSymbols = lUsedSymbols;
     usedSymbolsRuleKey = lUsedSymbolsRuleKey;
   }
-
-  if ( hasStyleOverride )
-    vl->styleManager()->restoreOverrideStyle();
 }