Reformat code

Author: nyalldawson

tests/src/python/test_qgsvectorlayer.py

@@ -63,6 +63,7 @@
 from qgis.testing import start_app, unittest
 from featuresourcetestbase import FeatureSourceTestCase
 from utilities import unitTestDataPath
+
 start_app()
 
 
@@ -353,6 +354,7 @@ def checkBefore():
 
         checkAfter()
         self.assertEqual(layer.dataProvider().featureCount(), 2)
+
     # DELETE FEATURE
 
     def test_DeleteFeature(self):
@@ -738,12 +740,12 @@ def testUpdateFeature(self):
 
         # change geometry and attributes
         f = features[0]
-        f.setAttributes(['new',321])
+        f.setAttributes(['new', 321])
         f.setGeometry(QgsGeometry.fromPointXY(QgsPointXY(-200, -200)))
         self.assertTrue(layer.updateFeature(f))
 
         new_feature = next(layer.getFeatures(QgsFeatureRequest(f.id())))
-        self.assertEqual(new_feature.attributes(), ['new',321])
+        self.assertEqual(new_feature.attributes(), ['new', 321])
         self.assertEqual(new_feature.geometry().asPoint(), QgsPointXY(-200, -200))
 
         # add feature with no geometry
@@ -774,7 +776,8 @@ def testUpdateFeature(self):
     def test_AddAttribute(self):
         layer = createLayerWithOnePoint()
         fld1 = QgsField("fld1", QVariant.Int, "integer")
-        #fld2 = QgsField("fld2", QVariant.Int, "integer")
+
+        # fld2 = QgsField("fld2", QVariant.Int, "integer")
 
         def checkBefore():
             # check fields
@@ -1197,7 +1200,7 @@ def checkFieldNames(names):
         checkFieldNames(['fldtxt', 'fldint'])
         self.assertTrue(layer.renameAttribute(1, 'fldint2'))
         checkFieldNames(['fldtxt', 'fldint2'])
-        #add an attribute
+        # add an attribute
         self.assertTrue(layer.addAttribute(QgsField("flddouble", QVariant.Double, "double")))
         checkFieldNames(['fldtxt', 'fldint2', 'flddouble'])
         # rename it
@@ -1260,15 +1263,15 @@ def checkFieldNames(names):
         self.assertTrue(layer.renameAttribute(2, 'flddouble2'))
         checkFieldNames(['fldtxt2', 'fldint', 'flddouble2'])
 
-        #delete an attribute
+        # delete an attribute
         self.assertTrue(layer.deleteAttribute(0))
         checkFieldNames(['fldint', 'flddouble2'])
         # rename remaining
         self.assertTrue(layer.renameAttribute(0, 'fldint2'))
         checkFieldNames(['fldint2', 'flddouble2'])
         self.assertTrue(layer.renameAttribute(1, 'flddouble3'))
         checkFieldNames(['fldint2', 'flddouble3'])
-        #delete an attribute
+        # delete an attribute
         self.assertTrue(layer.deleteAttribute(0))
         checkFieldNames(['flddouble3'])
         self.assertTrue(layer.renameAttribute(0, 'flddouble4'))
@@ -1289,16 +1292,16 @@ def checkFieldNames(names):
         layer.undoStack().undo()
         checkFieldNames(['fldtxt', 'fldint', 'flddouble'])
 
-        #layer.undoStack().redo()
-        #checkFieldNames(['fldtxt2', 'fldint'])
-        #layer.undoStack().redo()
-        #checkFieldNames(['fldint'])
+        # layer.undoStack().redo()
+        # checkFieldNames(['fldtxt2', 'fldint'])
+        # layer.undoStack().redo()
+        # checkFieldNames(['fldint'])
 
     def test_RenameExpressionField(self):
         layer = createLayerWithOnePoint()
         exp_field_idx = layer.addExpressionField('1+1', QgsField('math_is_hard', QVariant.Int))
 
-        #rename and check
+        # rename and check
         self.assertTrue(layer.renameAttribute(exp_field_idx, 'renamed'))
         self.assertEqual(layer.fields()[exp_field_idx].name(), 'renamed')
         f = next(layer.getFeatures())
@@ -1559,7 +1562,8 @@ def testUniqueStringsMatching(self):
         f1_id = next(layer.getFeatures()).id()
         self.assertTrue(layer.changeAttributeValue(f1_id, 0, 'coconut'))
         # note - this isn't 100% accurate, since orange no longer exists - but it avoids looping through all features
-        self.assertEqual(set(layer.uniqueStringsMatching(0, 'n')), set(['orange', 'BanaNa', 'waterMelon', 'pineapple', 'coconut']))
+        self.assertEqual(set(layer.uniqueStringsMatching(0, 'n')),
+                         set(['orange', 'BanaNa', 'waterMelon', 'pineapple', 'coconut']))
 
     def testMinValue(self):
         """ test retrieving minimum values """
@@ -1638,7 +1642,7 @@ def test_InvalidOperations(self):
         self.assertFalse(layer.deleteFeature(-333))
         # we do not check for existence of the feature id if it's
         # not newly added feature
-        #self.assertFalse(layer.deleteFeature(333))
+        # self.assertFalse(layer.deleteFeature(333))
 
         # CHANGE GEOMETRY
 
@@ -1712,7 +1716,7 @@ def test_ExpressionField(self):
         self.assertEqual(fet['test2'], NULL)
 
     def test_ExpressionFieldEllipsoidLengthCalculation(self):
-        #create a temporary layer
+        # create a temporary layer
         temp_layer = QgsVectorLayer("LineString?crs=epsg:3111&field=pk:int", "vl", "memory")
         self.assertTrue(temp_layer.isValid())
         f1 = QgsFeature(temp_layer.dataProvider().fields(), 1)
@@ -1740,12 +1744,14 @@ def test_ExpressionFieldEllipsoidLengthCalculation(self):
         self.assertAlmostEqual(f['length'], expected, 3)
 
     def test_ExpressionFieldEllipsoidAreaCalculation(self):
-        #create a temporary layer
+        # create a temporary layer
         temp_layer = QgsVectorLayer("Polygon?crs=epsg:3111&field=pk:int", "vl", "memory")
         self.assertTrue(temp_layer.isValid())
         f1 = QgsFeature(temp_layer.dataProvider().fields(), 1)
         f1.setAttribute("pk", 1)
-        f1.setGeometry(QgsGeometry.fromPolygonXY([[QgsPointXY(2484588, 2425722), QgsPointXY(2482767, 2398853), QgsPointXY(2520109, 2397715), QgsPointXY(2520792, 2425494), QgsPointXY(2484588, 2425722)]]))
+        f1.setGeometry(QgsGeometry.fromPolygonXY([[QgsPointXY(2484588, 2425722), QgsPointXY(2482767, 2398853),
+                                                   QgsPointXY(2520109, 2397715), QgsPointXY(2520792, 2425494),
+                                                   QgsPointXY(2484588, 2425722)]]))
         temp_layer.dataProvider().addFeatures([f1])
 
         # set project CRS and ellipsoid
@@ -1774,11 +1780,11 @@ def test_ExpressionFilter(self):
 
         features = layer.getFeatures(QgsFeatureRequest().setFilterExpression('"test" = 6'))
 
-        assert(len(list(features)) == 0)
+        assert (len(list(features)) == 0)
 
         features = layer.getFeatures(QgsFeatureRequest().setFilterExpression('"test" = 5'))
 
-        assert(len(list(features)) == 1)
+        assert (len(list(features)) == 1)
 
     def testSelectByIds(self):
         """ Test selecting by ID"""
@@ -2198,14 +2204,16 @@ def testGetSetConstraints(self):
         layer.setFieldConstraint(1, QgsFieldConstraints.ConstraintNotNull)
         layer.setFieldConstraint(1, QgsFieldConstraints.ConstraintUnique)
         self.assertEqual(layer.fieldConstraints(0), QgsFieldConstraints.ConstraintNotNull)
-        self.assertEqual(layer.fieldConstraints(1), QgsFieldConstraints.ConstraintNotNull | QgsFieldConstraints.ConstraintUnique)
+        self.assertEqual(layer.fieldConstraints(1),
+                         QgsFieldConstraints.ConstraintNotNull | QgsFieldConstraints.ConstraintUnique)
         self.assertFalse(layer.fieldConstraints(2))
         self.assertEqual(layer.fields().at(0).constraints().constraints(), QgsFieldConstraints.ConstraintNotNull)
         self.assertEqual(layer.fields().at(0).constraints().constraintOrigin(QgsFieldConstraints.ConstraintNotNull),
                          QgsFieldConstraints.ConstraintOriginLayer)
         self.assertEqual(layer.fields().at(0).constraints().constraintStrength(QgsFieldConstraints.ConstraintNotNull),
                          QgsFieldConstraints.ConstraintStrengthHard)
-        self.assertEqual(layer.fields().at(1).constraints().constraints(), QgsFieldConstraints.ConstraintNotNull | QgsFieldConstraints.ConstraintUnique)
+        self.assertEqual(layer.fields().at(1).constraints().constraints(),
+                         QgsFieldConstraints.ConstraintNotNull | QgsFieldConstraints.ConstraintUnique)
         self.assertEqual(layer.fields().at(1).constraints().constraintOrigin(QgsFieldConstraints.ConstraintNotNull),
                          QgsFieldConstraints.ConstraintOriginLayer)
         self.assertEqual(layer.fields().at(1).constraints().constraintOrigin(QgsFieldConstraints.ConstraintUnique),
@@ -2257,13 +2265,15 @@ def testSaveRestoreConstraints(self):
         layer3 = createLayerWithOnePoint()
         self.assertTrue(layer3.readXml(elem, QgsReadWriteContext()))
         self.assertEqual(layer3.fieldConstraints(0), QgsFieldConstraints.ConstraintNotNull)
-        self.assertEqual(layer3.fieldConstraints(1), QgsFieldConstraints.ConstraintNotNull | QgsFieldConstraints.ConstraintUnique)
+        self.assertEqual(layer3.fieldConstraints(1),
+                         QgsFieldConstraints.ConstraintNotNull | QgsFieldConstraints.ConstraintUnique)
         self.assertEqual(layer3.fields().at(0).constraints().constraints(), QgsFieldConstraints.ConstraintNotNull)
         self.assertEqual(layer3.fields().at(0).constraints().constraintOrigin(QgsFieldConstraints.ConstraintNotNull),
                          QgsFieldConstraints.ConstraintOriginLayer)
         self.assertEqual(layer.fields().at(0).constraints().constraintStrength(QgsFieldConstraints.ConstraintNotNull),
                          QgsFieldConstraints.ConstraintStrengthHard)
-        self.assertEqual(layer3.fields().at(1).constraints().constraints(), QgsFieldConstraints.ConstraintNotNull | QgsFieldConstraints.ConstraintUnique)
+        self.assertEqual(layer3.fields().at(1).constraints().constraints(),
+                         QgsFieldConstraints.ConstraintNotNull | QgsFieldConstraints.ConstraintUnique)
         self.assertEqual(layer3.fields().at(1).constraints().constraintOrigin(QgsFieldConstraints.ConstraintNotNull),
                          QgsFieldConstraints.ConstraintOriginLayer)
         self.assertEqual(layer3.fields().at(1).constraints().constraintOrigin(QgsFieldConstraints.ConstraintUnique),
@@ -2605,7 +2615,8 @@ def testFeatureRequestWithReprojectionAndVirtualFields(self):
         self.assertAlmostEqual(virtual_values[4], -65.32, 2)
 
         # repeat, with reprojection on request
-        request = QgsFeatureRequest().setDestinationCrs(QgsCoordinateReferenceSystem('epsg:3785'), QgsProject.instance().transformContext())
+        request = QgsFeatureRequest().setDestinationCrs(QgsCoordinateReferenceSystem('epsg:3785'),
+                                                        QgsProject.instance().transformContext())
         features = [f for f in layer.getFeatures(request)]
         # virtual field value should not change, even though geometry has
         self.assertAlmostEqual(features[0]['virtual'], -71.123, 2)