Skip to content
Permalink
Browse files

Reorder attribute type dialog

  • Loading branch information
m-kuhn committed Dec 20, 2016
1 parent c9f8ac2 commit d6cc6bdc909f6974cc7e29c94d144a63dc3df7e1
Showing with 4 additions and 4 deletions.
  1. +4 −4 src/ui/qgsattributetypeedit.ui
@@ -14,7 +14,7 @@
<string>Edit Widget Properties</string>
</property>
<layout class="QGridLayout" name="gridLayout">
<item row="0" column="1">
<item row="1" column="1">
<widget class="QgsCollapsibleGroupBox" name="groupBox">
<property name="title">
<string>Constraints</string>
@@ -101,7 +101,7 @@
</layout>
</widget>
</item>
<item row="5" column="1">
<item row="6" column="1">
<widget class="QDialogButtonBox" name="buttonBox">
<property name="orientation">
<enum>Qt::Horizontal</enum>
@@ -111,7 +111,7 @@
</property>
</widget>
</item>
<item row="0" column="0">
<item row="1" column="0">
<layout class="QGridLayout" name="gridLayout_4">
<item row="0" column="0">
<widget class="QCheckBox" name="isFieldEditableCheckBox">
@@ -172,7 +172,7 @@
</item>
</layout>
</item>
<item row="4" column="0" colspan="2">
<item row="0" column="0" colspan="2">
<widget class="QGroupBox" name="groupBox_3">
<property name="title">
<string>Widget Type</string>

5 comments on commit d6cc6bd

@DelazJ

This comment has been minimized.

Copy link
Contributor

@DelazJ DelazJ replied Dec 27, 2016

@m-kuhn any particular reason to have inverted the order of the widgets? I find it a bit ugly/awkward:

  • to have to select a particular widget at the top while general setting of the field's behavior is at the bottom.
  • this blank space at the top of the dialog (which will occur for most of the widgets)
    image
@m-kuhn

This comment has been minimized.

Copy link
Member Author

@m-kuhn m-kuhn replied Dec 27, 2016

It was mostly based on my personal frequency of usage, the more often used one on top. But no strong opinion.

@DelazJ

This comment has been minimized.

Copy link
Contributor

@DelazJ DelazJ replied Dec 27, 2016

Hummm... There were not so many features at the top before (and mainly nothing to change). but with all the new features (constraints and default) provided now, I wonder if these won't be the most used.
I'm not a frequent user of this dialog so my comments are based on the impression I had and not my habits.

@m-kuhn

This comment has been minimized.

Copy link
Member Author

@m-kuhn m-kuhn replied Dec 27, 2016

I actually still would very much like to implement something similar to qgis/QGIS-Enhancement-Proposals#37

We could also switch the list view to a combobox for the moment.

@DelazJ

This comment has been minimized.

Copy link
Contributor

@DelazJ DelazJ replied Dec 27, 2016

ok. +1 for the QEP. Then, Let's not spend time on this issue..
Thanks for your availability

Please sign in to comment.
You can’t perform that action at this time.