Skip to content

Commit da7cc96

Browse files
committed
Expression callTips are lowercase
Expressions are case insensitive but in all the apis and samples lower case is used. Be conform.
1 parent 4b9cc9b commit da7cc96

File tree

2 files changed

+25
-1
lines changed

2 files changed

+25
-1
lines changed

src/gui/qgscodeeditorexpression.cpp

+17-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ void QgsCodeEditorExpression::initializeLexer()
118118

119119
void QgsCodeEditorExpression::updateApis()
120120
{
121-
mApis = new QsciAPIs( mSqlLexer );
121+
mApis = new QgsSciApisExpression( mSqlLexer );
122122

123123
for ( const QString &var : qgis::as_const( mVariables ) )
124124
{
@@ -164,4 +164,20 @@ const char *QgsLexerExpression::wordCharacters() const
164164
{
165165
return "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ_@";
166166
}
167+
168+
QgsSciApisExpression::QgsSciApisExpression( QsciLexer *lexer )
169+
: QsciAPIs( lexer )
170+
{
171+
172+
}
173+
174+
QStringList QgsSciApisExpression::callTips( const QStringList &context, int commas, QsciScintilla::CallTipsStyle style, QList<int> &shifts )
175+
{
176+
const QStringList originalTips = QsciAPIs::callTips( context, commas, style, shifts );
177+
QStringList lowercaseTips;
178+
for ( const QString &tip : originalTips )
179+
lowercaseTips << tip.toLower();
180+
181+
return lowercaseTips;
182+
}
167183
///@endcond

src/gui/qgscodeeditorexpression.h

+8
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,14 @@ class QgsLexerExpression : public QsciLexerSQL
9191

9292
const char *wordCharacters() const override;
9393
};
94+
95+
class QgsSciApisExpression : public QsciAPIs
96+
{
97+
public:
98+
QgsSciApisExpression( QsciLexer *lexer );
99+
100+
QStringList callTips( const QStringList &context, int commas, QsciScintilla::CallTipsStyle style, QList<int> &shifts ) override;
101+
};
94102
///@endcond
95103
#endif
96104

0 commit comments

Comments
 (0)