Skip to content

Commit db00cb1

Browse files
committed
Resurrect a processing test
1 parent df07772 commit db00cb1

File tree

2 files changed

+25
-21
lines changed

2 files changed

+25
-21
lines changed

.ci/travis/linux/blacklist.txt

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ PyQgsDBManagerGpkg
1010

1111
# temporary during processing refactoring
1212
ProcessingParametersTest
13-
ProcessingModelerTest
1413
ProcessingGdalAlgorithmsTest
1514

1615
# layout tests are run on separate build

python/plugins/processing/tests/ModelerTest.py

+25-20
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@
2727

2828
from qgis.testing import start_app, unittest
2929

30-
from processing.modeler.ModelerAlgorithm import (Algorithm,
31-
ModelerAlgorithm,
32-
ModelerParameter,
33-
ModelerOutput,
34-
ValueFromOutput)
30+
from qgis.core import (QgsProcessingModelAlgorithm,
31+
QgsProcessingParameterString,
32+
QgsProcessingParameterNumber,
33+
QgsProcessingParameterField,
34+
QgsProcessingParameterFile)
3535
from processing.modeler.ModelerParametersDialog import (ModelerParametersDialog)
3636
from processing.core.parameters import (ParameterFile,
3737
ParameterNumber,
@@ -45,29 +45,34 @@ class ModelerTest(unittest.TestCase):
4545
def testModelerParametersDialogAvailableValuesOfType(self):
4646
# test getAvailableValuesOfType from ModelerParametersDialog
4747

48-
m = ModelerAlgorithm()
49-
string_param_1 = ModelerParameter(ParameterString('string', 'string desc'))
50-
m.addParameter(string_param_1)
51-
string_param_2 = ModelerParameter(ParameterString('string2', 'string desc'))
52-
m.addParameter(string_param_2)
53-
num_param = ModelerParameter(ParameterNumber('number', 'number desc'))
54-
m.addParameter(num_param)
55-
table_field_param = ModelerParameter(ParameterTableField('field', 'field desc'))
56-
m.addParameter(table_field_param)
57-
file_param = ModelerParameter(ParameterFile('file', 'file desc'))
58-
m.addParameter(file_param)
48+
m = QgsProcessingModelAlgorithm()
49+
50+
string_param_1 = QgsProcessingModelAlgorithm.ModelParameter('string')
51+
m.addModelParameter(QgsProcessingParameterString('string'), string_param_1)
52+
53+
string_param_2 = QgsProcessingModelAlgorithm.ModelParameter('string2')
54+
m.addModelParameter(QgsProcessingParameterString('string2'), string_param_2)
55+
56+
num_param = QgsProcessingModelAlgorithm.ModelParameter('number')
57+
m.addModelParameter(QgsProcessingParameterNumber('number'), num_param)
58+
59+
table_field_param = QgsProcessingModelAlgorithm.ModelParameter('field')
60+
m.addModelParameter(QgsProcessingParameterField('field'), table_field_param)
61+
62+
file_param = QgsProcessingModelAlgorithm.ModelParameter('file')
63+
m.addModelParameter(QgsProcessingParameterFile('file'), file_param)
5964

6065
dlg = ModelerParametersDialog(m, m)
6166
# test single types
62-
self.assertEqual(set(p.name for p in dlg.getAvailableValuesOfType(ParameterNumber)),
67+
self.assertEqual(set(p.parameterName() for p in dlg.getAvailableValuesOfType(QgsProcessingParameterNumber)),
6368
set(['number']))
64-
self.assertEqual(set(p.name for p in dlg.getAvailableValuesOfType(ParameterTableField)),
69+
self.assertEqual(set(p.parameterName() for p in dlg.getAvailableValuesOfType(QgsProcessingParameterField)),
6570
set(['field']))
66-
self.assertEqual(set(p.name for p in dlg.getAvailableValuesOfType(ParameterFile)),
71+
self.assertEqual(set(p.parameterName() for p in dlg.getAvailableValuesOfType(QgsProcessingParameterFile)),
6772
set(['file']))
6873

6974
# test multiple types
70-
self.assertEqual(set(p.name for p in dlg.getAvailableValuesOfType([ParameterString, ParameterNumber, ParameterFile])),
75+
self.assertEqual(set(p.parameterName() for p in dlg.getAvailableValuesOfType([QgsProcessingParameterString, QgsProcessingParameterNumber, QgsProcessingParameterFile])),
7176
set(['string', 'string2', 'number', 'file']))
7277

7378

0 commit comments

Comments
 (0)