Skip to content

Commit dc0d240

Browse files
committed
[sextante] fix parameters handling in some GDAL algorithms
1 parent dc15292 commit dc0d240

File tree

3 files changed

+29
-18
lines changed

3 files changed

+29
-18
lines changed

python/plugins/sextante/gdal/gdaladdo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def processAlgorithm(self, progress):
5656
arguments = []
5757
inFile = self.getParameterValue(gdaladdo.INPUT)
5858
arguments.append(inFile)
59-
arguments.append(self.getParameterValue(gdaladdo.LEVELS))
59+
arguments.extend(self.getParameterValue(gdaladdo.LEVELS).split(" "))
6060
self.setOutputValue(gdaladdo.OUTPUT, inFile)
6161

6262
GdalUtils.runGdal(["gdaladdo", GdalUtils.escapeAndJoin(arguments)], progress)

python/plugins/sextante/gdal/translate.py

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,10 @@ def defineCharacteristics(self):
6868
self.addParameter(ParameterCrs(translate.SRS, "Override the projection for the output file", None))
6969
self.addParameter(ParameterExtent(translate.PROJWIN, "Subset based on georeferenced coordinates"))
7070
self.addParameter(ParameterBoolean(translate.SDS, "Copy all subdatasets of this file to individual output files", False))
71-
self.addParameter(ParameterString(translate.EXTRA, "Additional creation parameters", " "))
71+
self.addParameter(ParameterString(translate.EXTRA, "Additional creation parameters", ""))
7272
self.addOutput(OutputRaster(translate.OUTPUT, "Output layer"))
7373

7474
def processAlgorithm(self, progress):
75-
7675
out = self.getOutputValue(translate.OUTPUT)
7776
outsize = str(self.getParameterValue(translate.OUTSIZE))
7877
outsizePerc = str(self.getParameterValue(translate.OUTSIZE_PERC))
@@ -87,20 +86,31 @@ def processAlgorithm(self, progress):
8786
arguments.append("-of")
8887
arguments.append(GdalUtils.getFormatShortNameFromFilename(out))
8988
if outsizePerc == "True":
90-
outsizeStr = "-outsize " + outsize + "% " + outsize + "%"
89+
arguments.append("-outsize")
90+
arguments.append(outsize + "%")
91+
arguments.append(outsize + "%")
9192
else:
92-
outsizeStr = "-outsize " + outsize + " " + outsize
93-
arguments.append(outsizeStr)
94-
arguments.append("-a_nodata " + noData)
93+
arguments.append("-outsize")
94+
arguments.append(outsize)
95+
arguments.append(outsize)
96+
arguments.append("-a_nodata")
97+
arguments.append(noData)
9598
if expand != "none":
96-
arguments.append("-expand " + expand)
99+
arguments.append("-expand")
100+
arguments.append(expand)
97101
regionCoords = projwin.split(",")
98-
arguments.append("-projwin " + regionCoords[0] + " " + regionCoords[3] + " " + regionCoords[1] + " " + regionCoords[2])
102+
arguments.append("-projwin")
103+
arguments.append(regionCoords[0])
104+
arguments.append(regionCoords[3])
105+
arguments.append(regionCoords[1])
106+
arguments.append(regionCoords[2])
99107
if srs is not None:
100-
arguments.append("-a_srs " + str(srs))
108+
arguments.append("-a_srs")
109+
arguments.append(str(srs))
101110
if sds:
102111
arguments.append("-sds")
103-
arguments.append(extra)
112+
if len(extra) > 0:
113+
arguments.append(extra)
104114
arguments.append(self.getParameterValue(translate.INPUT))
105115
arguments.append(out)
106116

python/plugins/sextante/gdal/warp.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,26 +62,27 @@ def defineCharacteristics(self):
6262
self.addParameter(ParameterCrs(warp.DEST_SRS, "Destination SRS (EPSG Code)", "EPSG:4326"))
6363
self.addParameter(ParameterNumber(warp.TR, "Output file resolution in target georeferenced units (leave 0 for no change)", 0.0, None, 0.0))
6464
self.addParameter(ParameterSelection(warp.METHOD, "Resampling method", warp.METHOD_OPTIONS))
65-
self.addParameter(ParameterString(warp.EXTRA, "Additional creation parameters", " "))
65+
self.addParameter(ParameterString(warp.EXTRA, "Additional creation parameters", ""))
6666
self.addOutput(OutputRaster(warp.OUTPUT, "Output layer"))
6767

6868
def processAlgorithm(self, progress):
69-
srs = self.getParameterValue(warp.DEST_SRS)
70-
self.crs = QgsCoordinateReferenceSystem(srs)
7169
arguments = []
7270
arguments.append("-s_srs")
7371
arguments.append(str(self.getParameterValue(warp.SOURCE_SRS)))
7472
arguments.append("-t_srs")
75-
arguments.append(str(srs))
73+
arguments.append(str(self.getParameterValue(warp.DEST_SRS)))
7674
arguments.append("-r")
7775
arguments.append(warp.METHOD_OPTIONS[self.getParameterValue(warp.METHOD)])
7876
arguments.append("-of")
7977
out = self.getOutputValue(warp.OUTPUT)
8078
arguments.append(GdalUtils.getFormatShortNameFromFilename(out))
8179
if self.getParameterValue(warp.TR) != 0:
82-
trStr = "-tr " + str(self.getParameterValue(warp.TR)) + " " + str(self.getParameterValue(warp.TR))
83-
arguments.append(trStr)
84-
arguments.append(str(self.getParameterValue(warp.EXTRA)))
80+
arguments.append("-tr")
81+
arguments.append(str(self.getParameterValue(warp.TR)))
82+
arguments.append(str(self.getParameterValue(warp.TR)))
83+
extra = str(self.getParameterValue(warp.EXTRA))
84+
if len(extra) > 0:
85+
arguments.append(extra)
8586
arguments.append(self.getParameterValue(warp.INPUT))
8687
arguments.append(out)
8788

0 commit comments

Comments
 (0)