From dc8c3d9141ade161829218c497ec416ce42eb2b8 Mon Sep 17 00:00:00 2001 From: Audun Ellertsen Date: Mon, 25 May 2020 20:03:03 +0200 Subject: [PATCH] Avoid leaking sqlite3_stmt on errors --- src/providers/spatialite/qgsspatialiteprovider.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/providers/spatialite/qgsspatialiteprovider.cpp b/src/providers/spatialite/qgsspatialiteprovider.cpp index 6cad148619c5..67aba16f081c 100644 --- a/src/providers/spatialite/qgsspatialiteprovider.cpp +++ b/src/providers/spatialite/qgsspatialiteprovider.cpp @@ -4362,6 +4362,7 @@ bool QgsSpatiaLiteProvider::deleteFeatures( const QgsFeatureIds &id ) errMsg = ( char * ) sqlite3_malloc( ( int ) strlen( err ) + 1 ); strcpy( errMsg, err ); handleError( sql, errMsg, savepointId ); + sqlite3_finalize( stmt ); return false; } } @@ -4643,6 +4644,7 @@ bool QgsSpatiaLiteProvider::changeGeometryValues( const QgsGeometryMap &geometry errMsg = ( char * ) sqlite3_malloc( ( int ) strlen( err ) + 1 ); strcpy( errMsg, err ); handleError( sql, errMsg, savepointId ); + sqlite3_finalize( stmt ); return false; } }