make conditional easier to read

qgis · May 11, 2023 · dd00077 · dd00077
1 parent 1bfa5ea
commit dd00077
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/3d/qgspointcloudlayer3drenderer.cpp b/src/3d/qgspointcloudlayer3drenderer.cpp
@@ -153,21 +153,21 @@ QgsPointCloudLayer3DRenderer *QgsPointCloudLayer3DRenderer::clone() const
 Qt3DCore::QEntity *QgsPointCloudLayer3DRenderer::createEntity( const Qgs3DMapSettings &map ) const
 {
   QgsPointCloudLayer *pcl = layer();
-  if ( !pcl || !pcl->dataProvider() || ( !pcl->dataProvider()->index() && pcl->dataProvider()->subIndexes().isEmpty() ) )
+  if ( !pcl || !pcl->dataProvider() )
     return nullptr;
   if ( !mSymbol )
     return nullptr;
 
   const QgsCoordinateTransform coordinateTransform( pcl->crs(), map.crs(), map.transformContext() );
 
-  Qt3DCore::QEntity *entity;
+  Qt3DCore::QEntity *entity = nullptr;
   if ( pcl->dataProvider()->index() )
   {
     entity = new QgsPointCloudLayerChunkedEntity( pcl->dataProvider()->index(), map, coordinateTransform, dynamic_cast<QgsPointCloud3DSymbol *>( mSymbol->clone() ), maximumScreenError(), showBoundingBoxes(),
         static_cast< const QgsPointCloudLayerElevationProperties * >( pcl->elevationProperties() )->zScale(),
         static_cast< const QgsPointCloudLayerElevationProperties * >( pcl->elevationProperties() )->zOffset(), mPointBudget );
   }
-  else
+  else if ( !pcl->dataProvider()->subIndexes().isEmpty() )
   {
     entity = new QgsVirtualPointCloudEntity( pcl, map, coordinateTransform, dynamic_cast<QgsPointCloud3DSymbol *>( mSymbol->clone() ), maximumScreenError(), showBoundingBoxes(),
         static_cast< const QgsPointCloudLayerElevationProperties * >( pcl->elevationProperties() )->zScale(),