Skip to content

Commit

Permalink
Removed some TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
elpaso committed Jan 9, 2018
1 parent 680b9f8 commit dd0cce2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions src/core/layout/qgscompositionconverter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ QList<QgsLayoutItem *> QgsCompositionConverter::addItemsFromCompositionXml( QgsL
// known multi-frame types
LayoutHtml, //!< Html multiframe item
LayoutAttributeTable, //!< Attribute table
LayoutTextTable, //!< Preset text table
LayoutTextTable, //!< Preset text table IGNORE!
*/

// Label
Expand Down Expand Up @@ -249,7 +249,7 @@ QList<QgsLayoutItem *> QgsCompositionConverter::addItemsFromCompositionXml( QgsL
newItems << layoutItem ;
}

// Polygon TODO:frames and background are ignored: is that ok?
// Polygon
for ( int i = 0; i < parentElement.elementsByTagName( QStringLiteral( "ComposerPolygon" ) ).size(); i++ )
{
QDomNode itemNode( parentElement.elementsByTagName( QStringLiteral( "ComposerPolygon" ) ).at( i ) );
Expand All @@ -259,7 +259,7 @@ QList<QgsLayoutItem *> QgsCompositionConverter::addItemsFromCompositionXml( QgsL
newItems << layoutItem ;
}

// Polyline TODO:frames and background are ignored: is that ok?
// Polylin
for ( int i = 0; i < parentElement.elementsByTagName( QStringLiteral( "ComposerPolyline" ) ).size(); i++ )
{
QDomNode itemNode( parentElement.elementsByTagName( QStringLiteral( "ComposerPolyline" ) ).at( i ) );
Expand All @@ -269,7 +269,7 @@ QList<QgsLayoutItem *> QgsCompositionConverter::addItemsFromCompositionXml( QgsL
newItems << layoutItem ;
}

// Arrow TODO:frames and background are ignored: is that ok?
// Arrow
for ( int i = 0; i < parentElement.elementsByTagName( QStringLiteral( "ComposerArrow" ) ).size(); i++ )
{
QDomNode itemNode( parentElement.elementsByTagName( QStringLiteral( "ComposerArrow" ) ).at( i ) );
Expand Down
2 changes: 1 addition & 1 deletion src/core/layout/qgscompositionconverter.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
---------------------
begin : 13.12.2017
copyright : (C) 2017 by Alessandro Pasotti
email : apasotti at boundlessgeo dot com
email : elpaso at itopen dot it
***************************************************************************
* *
* This program is free software; you can redistribute it and/or modify *
Expand Down

0 comments on commit dd0cce2

Please sign in to comment.