Skip to content

Commit

Permalink
Reenable full task manager tests following b45469f
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Jan 19, 2017
1 parent 16eac9f commit dd61445
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions tests/src/core/testqgstaskmanager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,7 @@ class TestQgsTaskManager : public QObject
void task();
void taskResult();
void taskFinished();
#if 0 //flaky
void subTask();
#endif
void addTask();
void taskTerminationBeforeDelete();
void taskId();
Expand Down Expand Up @@ -432,7 +430,6 @@ void TestQgsTaskManager::taskFinished()
QCOMPARE( *resultObtained, false );
}

#if 0 //flaky
void TestQgsTaskManager::subTask()
{
QgsTaskManager manager;
Expand Down Expand Up @@ -631,7 +628,6 @@ void TestQgsTaskManager::subTask()
flushEvents();
QVERIFY( parentFinished2.count() > 0 );
}
#endif

void TestQgsTaskManager::taskId()
{
Expand Down Expand Up @@ -1073,7 +1069,7 @@ void TestQgsTaskManager::managerWithSubTasks()
QCOMPARE( manager->activeTasks().count(), 1 );
QVERIFY( manager->activeTasks().contains( parent ) );
QCOMPARE( spy.count(), 1 );
#if 0 // flaky

//manager should not directly listen to progress reports from subtasks
//(only parent tasks, which themselves include their subtask progress)
QCOMPARE( spyProgress.count(), 0 );
Expand All @@ -1094,7 +1090,6 @@ void TestQgsTaskManager::managerWithSubTasks()
QCOMPARE( spyProgress.count(), 3 );
QCOMPARE( spyProgress.last().at( 0 ).toLongLong(), 0LL );
QCOMPARE( spyProgress.last().at( 1 ).toInt(), 63 );
#endif

//manager should not emit statusChanged signals for subtasks
QSignalSpy statusSpy( manager, &QgsTaskManager::statusChanged );
Expand Down

0 comments on commit dd61445

Please sign in to comment.