Skip to content


[needs-docs] Use a combo box in layout SVG settings dialog for text e…
Browse files Browse the repository at this point in the history
…xport format

This makes it match the label engine settings dialog, and opens the possibility
for additional text export modes to be added in future.

(cherry picked from commit 7b426c0)
  • Loading branch information
nyalldawson committed Dec 11, 2018
1 parent b6cc3f4 commit de18cc7
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 19 deletions.
8 changes: 6 additions & 2 deletions src/app/layout/qgslayoutdesignerdialog.cpp
Expand Up @@ -4000,7 +4000,11 @@ bool QgsLayoutDesignerDialog::getSvgExportSettings( QgsLayoutExporter::SvgExport
QDialog dialog;
Ui::QgsSvgExportOptionsDialog options;
options.setupUi( &dialog );
options.chkTextAsOutline->setChecked( prevTextRenderFormat == QgsRenderContext::TextFormatAlwaysOutlines );

options.mTextRenderFormatComboBox->addItem( tr( "Always Export Text as Paths (Recommended)" ), QgsRenderContext::TextFormatAlwaysOutlines );
options.mTextRenderFormatComboBox->addItem( tr( "Always Export Text as Text Objects" ), QgsRenderContext::TextFormatAlwaysText );

options.mTextRenderFormatComboBox->setCurrentIndex( options.mTextRenderFormatComboBox->findData( prevTextRenderFormat ) );
options.chkMapLayersAsGroup->setChecked( layersAsGroup );
options.mClipToContentGroupBox->setChecked( cropToContents );
options.mForceVectorCheckBox->setChecked( previousForceVector );
Expand All @@ -4020,7 +4024,7 @@ bool QgsLayoutDesignerDialog::getSvgExportSettings( QgsLayoutExporter::SvgExport
marginBottom = options.mBottomMarginSpinBox->value();
marginLeft = options.mLeftMarginSpinBox->value();
includeMetadata = options.mIncludeMetadataCheckbox->isChecked();
QgsRenderContext::TextRenderFormat textRenderFormat = options.chkTextAsOutline->isChecked() ? QgsRenderContext::TextFormatAlwaysOutlines : QgsRenderContext::TextFormatAlwaysText;
QgsRenderContext::TextRenderFormat textRenderFormat = static_cast< QgsRenderContext::TextRenderFormat >( options.mTextRenderFormatComboBox->currentData().toInt() );

if ( mLayout )
Expand Down
28 changes: 11 additions & 17 deletions src/ui/layout/qgssvgexportoptions.ui
Expand Up @@ -19,8 +19,8 @@
<property name="title">
<string>SVG Options</string>
<layout class="QVBoxLayout" name="verticalLayout_2">
<layout class="QGridLayout" name="gridLayout" columnstretch="0,1">
<item row="0" column="0" colspan="2">
<widget class="QCheckBox" name="chkMapLayersAsGroup">
<property name="text">
<string>Export map layers as SVG groups (may affect label placement)</string>
Expand All @@ -30,23 +30,17 @@
<widget class="QCheckBox" name="chkTextAsOutline">
<property name="enabled">
<property name="toolTip">
<string>Uncheck to render map labels as text objects. This will degrade the quality of the map labels but allow editing in vector illustration software.</string>
<item row="3" column="1">
<widget class="QComboBox" name="mTextRenderFormatComboBox"/>
<item row="3" column="0">
<widget class="QLabel" name="label_6">
<property name="text">
<string>Render map labels as outlines</string>
<property name="checked">
<string>Text export</string>
<item row="1" column="0" colspan="2">
<widget class="QCheckBox" name="mForceVectorCheckBox">
<property name="toolTip">
<string>If checked, the layout will always be kept as vector objects when exported to a compatible format, even if the appearance of the resultant file does not match the layouts settings. If unchecked, some elements in the layout may be rasterized in order to keep their appearance intact.</string>
Expand All @@ -56,7 +50,7 @@
<item row="2" column="0" colspan="2">
<widget class="QCheckBox" name="mIncludeMetadataCheckbox">
<property name="text">
<string>Export RDF metadata</string>
Expand Down Expand Up @@ -214,9 +208,9 @@
Expand Down

0 comments on commit de18cc7

Please sign in to comment.