Use qgsgeometry_cast rather than dynamic_cast

m-kuhn · m-kuhn · commit e300387b521c · 2018-10-15T14:28:01.000+02:00
diff --git a/src/analysis/vector/geometry_checker/qgsgeometrycheckerutils.cpp b/src/analysis/vector/geometry_checker/qgsgeometrycheckerutils.cpp
@@ -302,12 +302,12 @@ QList<const QgsLineString *> QgsGeometryCheckerUtils::polygonRings( const QgsPol
 
 void QgsGeometryCheckerUtils::filter1DTypes( QgsAbstractGeometry *geom )
 {
-  if ( dynamic_cast<QgsGeometryCollection *>( geom ) )
+  if ( qgsgeometry_cast<QgsGeometryCollection *>( geom ) )
   {
     QgsGeometryCollection *geomCollection = static_cast<QgsGeometryCollection *>( geom );
     for ( int nParts = geom->partCount(), iPart = nParts - 1; iPart >= 0; --iPart )
     {
-      if ( !dynamic_cast<QgsSurface *>( geomCollection->geometryN( iPart ) ) )
+      if ( !qgsgeometry_cast<QgsSurface *>( geomCollection->geometryN( iPart ) ) )
       {
         geomCollection->removeGeometry( iPart );
       }

Original file line number	Diff line number	Diff line change
`@@ -302,12 +302,12 @@ QList<const QgsLineString *> QgsGeometryCheckerUtils::polygonRings( const QgsPol`
`302`	`302`
`303`	`303`	`void QgsGeometryCheckerUtils::filter1DTypes( QgsAbstractGeometry *geom )`
`304`	`304`	`{`
`305`		`- if ( dynamic_cast<QgsGeometryCollection *>( geom ) )`
	`305`	`+ if ( qgsgeometry_cast<QgsGeometryCollection *>( geom ) )`
`306`	`306`	`{`
`307`	`307`	`QgsGeometryCollection geomCollection = static_cast<QgsGeometryCollection >( geom );`
`308`	`308`	`for ( int nParts = geom->partCount(), iPart = nParts - 1; iPart >= 0; --iPart )`
`309`	`309`	`{`
`310`		`- if ( !dynamic_cast<QgsSurface *>( geomCollection->geometryN( iPart ) ) )`
	`310`	`+ if ( !qgsgeometry_cast<QgsSurface *>( geomCollection->geometryN( iPart ) ) )`
`311`	`311`	`{`
`312`	`312`	`geomCollection->removeGeometry( iPart );`
`313`	`313`	`}`