Skip to content

Commit e72879e

Browse files
committed
unique_str for QgsRubberBand
1 parent 87fb27f commit e72879e

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

src/app/qgsmaptoolreverseline.cpp

+1-7
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ QgsMapToolReverseLine::QgsMapToolReverseLine( QgsMapCanvas *canvas )
3737

3838
QgsMapToolReverseLine::~QgsMapToolReverseLine()
3939
{
40-
delete mRubberBand;
4140
}
4241

4342
void QgsMapToolReverseLine::canvasMoveEvent( QgsMapMouseEvent *e )
@@ -50,8 +49,6 @@ void QgsMapToolReverseLine::canvasPressEvent( QgsMapMouseEvent *e )
5049
{
5150
mPressedFid = -1;
5251
mPressedPartNum = -1;
53-
delete mRubberBand;
54-
mRubberBand = nullptr;
5552

5653
QgsMapLayer *currentLayer = mCanvas->currentLayer();
5754
if ( !currentLayer )
@@ -74,7 +71,7 @@ void QgsMapToolReverseLine::canvasPressEvent( QgsMapMouseEvent *e )
7471

7572
if ( mPressedFid != -1 )
7673
{
77-
mRubberBand = createRubberBand( vlayer->geometryType() );
74+
mRubberBand.reset( createRubberBand( vlayer->geometryType() ) );
7875

7976
mRubberBand->setToGeometry( geomPart, vlayer );
8077
mRubberBand->show();
@@ -86,9 +83,6 @@ void QgsMapToolReverseLine::canvasReleaseEvent( QgsMapMouseEvent *e )
8683
{
8784
Q_UNUSED( e );
8885

89-
delete mRubberBand;
90-
mRubberBand = nullptr;
91-
9286
if ( !vlayer || !vlayer->isEditable() )
9387
{
9488
return;

src/app/qgsmaptoolreverseline.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ class APP_EXPORT QgsMapToolReverseLine: public QgsMapToolEdit
4444

4545
QgsGeometry partUnderPoint( QPoint p, QgsFeatureId &fid, int &partNum );
4646

47-
/* Rubberband that shows the part being deleted*/
48-
QgsRubberBand *mRubberBand = nullptr;
47+
/* Rubberband that shows the part being reversed*/
48+
std::unique_ptr<QgsRubberBand>mRubberBand;
4949

5050
//The feature and part where the mouse cursor was pressed
5151
//This is used to check whether we are still in the same part at cursor release

0 commit comments

Comments
 (0)