@@ -602,6 +602,36 @@ deserves your options to accelerate it should be (in order of priority):
602
602
* Send a message to the project steering committee asking them to help see your
603
603
PR incorporated into the code base.
604
604
605
+ ==== Best practice for creating a pull request ====
606
+
607
+ * Always start a feature branch from current master.
608
+ * If you are coding a feature branch, don't "merge" anything in other than
609
+ master (see below).
610
+ * Before you create a pull request do "git fetch origin" and "git rebase
611
+ origin/master" (given origin is the remote for upstream and not your own
612
+ remote, check your .git/config or do "git remote -v | grep github.com/qgis").
613
+ * You may do a "git rebase" like in the last line repeatedly without doing any
614
+ damage (as long as the only purpose of your branch is to get merged into
615
+ master).
616
+ * Attention: After a rebase you need to "git push -f" to your **forked repo**.
617
+ **CORE DEVS**: DO NOT DO THIS ON THE QGIS PUBLIC REPOSITORY!
618
+
619
+
620
+ ==== For merging a pull request ====
621
+
622
+ Option A
623
+
624
+ * click the merge button (Creates a non-fast-forward merge)
625
+
626
+ Option B
627
+
628
+ * Checkout the pull request (See https://gist.github.com/piscisaureus/3342247)
629
+ * Test (Also required for option A, obviously)
630
+ * checkout master, ``git merge pr/1234``
631
+ * Optional: ``git pull --rebase``: Creates a fast-forward, no "merge commit" is
632
+ made. Cleaner history, but it is harder to revert the merge.
633
+ * ``git push``
634
+
605
635
606
636
=== Patch file naming ===
607
637
0 commit comments