fix warnings

Author: jef-n

src/app/qgisapp.cpp

@@ -628,7 +628,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, QWidget * parent,
 
 #ifdef ANDROID
   //add reacting to long click in android
-  grabGesture(Qt::TapAndHoldGesture);
+  grabGesture( Qt::TapAndHoldGesture );
 #endif
 
   // update windows
@@ -741,9 +741,9 @@ bool QgisApp::event( QEvent * event )
     done = true;
   }
 #ifdef ANDROID
-  else if (event->type() == QEvent::Gesture )
+  else if ( event->type() == QEvent::Gesture )
   {
-    done = gestureEvent(static_cast<QGestureEvent*>(event));
+    done = gestureEvent( static_cast<QGestureEvent*>( event ) );
   }
 #endif
   else
@@ -7293,18 +7293,19 @@ QMenu* QgisApp::createPopupMenu()
 }
 
 #ifdef ANDROID
-bool QgisApp::gestureEvent(QGestureEvent *event)
+bool QgisApp::gestureEvent( QGestureEvent *event )
 {
-  if (QGesture *tapAndHold = event->gesture(Qt::TapAndHoldGesture))
+  if ( QGesture *tapAndHold = event->gesture( Qt::TapAndHoldGesture ) )
   {
-    tapAndHoldTriggered(static_cast<QTapAndHoldGesture *>(tapAndHold));
+    tapAndHoldTriggered( static_cast<QTapAndHoldGesture *>( tapAndHold ) );
   }
   return true;
 }
 
-void QgisApp::tapAndHoldTriggered(QTapAndHoldGesture *gesture)
+void QgisApp::tapAndHoldTriggered( QTapAndHoldGesture *gesture )
 {
-  if (gesture->state() == Qt::GestureFinished) {
+  if ( gesture->state() == Qt::GestureFinished )
+  {
     QPoint pos = gesture->position().toPoint();
     QWidget * receiver = QApplication::widgetAt( pos );
     qDebug() << "tapAndHoldTriggered: LONG CLICK gesture happened at " << pos;

src/app/qgisapp.h

@@ -1165,8 +1165,8 @@ class QgisApp : public QMainWindow, private Ui::MainWindow
     QString mOldScale;
 
 #ifdef ANDROID
-    bool gestureEvent(QGestureEvent *event);
-    void tapAndHoldTriggered(QTapAndHoldGesture *gesture);
+    bool gestureEvent( QGestureEvent *event );
+    void tapAndHoldTriggered( QTapAndHoldGesture *gesture );
 #endif
 };
 

src/app/qgsmaptooloffsetcurve.cpp

@@ -484,5 +484,6 @@ QgsGeometry* QgsMapToolOffsetCurve::convertToSingleLine( QgsGeometry* geom, int
 
 QgsGeometry* QgsMapToolOffsetCurve::convertToMultiLine( QgsGeometry* geom )
 {
+  Q_UNUSED( geom );
   return 0;
 }

src/core/qgsgeometry.cpp

@@ -6156,8 +6156,6 @@ QgsGeometry* QgsGeometry::combine( QgsGeometry* geometry )
   try
   {
     GEOSGeometry* unionGeom = GEOSUnion( mGeos, geometry->mGeos );
-    QGis::WkbType thisGeomType = wkbType();
-    QGis::WkbType otherGeomType = geometry->wkbType();
     if ( type() == QGis::Line )
     {
       GEOSGeometry* mergedGeom = GEOSLineMerge( unionGeom );

src/core/qgslabel.cpp

@@ -593,6 +593,8 @@ unsigned char* QgsLabel::labelPoint( labelpoint& point, unsigned char *geom, siz
   QGis::WkbType wkbType;
 #ifndef QT_NO_DEBUG
   unsigned char *geomend = geom + geomlen;
+#else
+  Q_UNUSED( geomlen );
 #endif
   Q_ASSERT( geom + 1 + sizeof( wkbType ) <= geomend );
 

src/providers/wms/qgswmsprovider.cpp

@@ -2959,7 +2959,7 @@ QStringList QgsWmsProvider::identifyAs( const QgsPoint& point, QString format )
         setQueryItem( requestUrl, "X", QString::number( point.x() ) );
         setQueryItem( requestUrl, "Y", QString::number( point.y() ) );
 
-        if( mFeatureCount > 0 )
+        if ( mFeatureCount > 0 )
         {
           setQueryItem( requestUrl, "FEATURE_COUNT", QString::number( mFeatureCount ) );
         }

src/providers/wms/qgswmssourceselect.cpp

@@ -473,7 +473,7 @@ void QgsWMSSourceSelect::addClicked()
 
   if ( mFeatureCount->text().toInt() > 0 )
   {
-    if( !connArgs.isEmpty() )
+    if ( !connArgs.isEmpty() )
       connArgs += ",";
     connArgs += QString( "featureCount=%1" ).arg( mFeatureCount->text().toInt() );
   }