add anchor to help URL only if necessary

alexbruy · alexbruy · commit eaa97f367e63 · 2017-02-14T21:00:04.000+02:00
diff --git a/src/gui/qgshelp.cpp b/src/gui/qgshelp.cpp
@@ -87,7 +87,11 @@ QUrl QgsHelp::helpUrl( const QString& key )
         continue;
       }
       helpUrl = QUrl::fromLocalFile( filePath );
-      helpUrl.setFragment( helpPath.mid( helpPath.lastIndexOf( "#" ) + 1, -1 ) );
+      int pos = helpPath.lastIndexOf( "#" );
+      if ( pos != -1 )
+      {
+        helpUrl.setFragment( helpPath.mid( helpPath.lastIndexOf( "#" ) + 1, -1 ) );
+      }
     }
 
     helpFound = true;

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,11 @@ QUrl QgsHelp::helpUrl( const QString& key )`
`87`	`87`	`continue;`
`88`	`88`	`}`
`89`	`89`	`helpUrl = QUrl::fromLocalFile( filePath );`
`90`		`- helpUrl.setFragment( helpPath.mid( helpPath.lastIndexOf( "#" ) + 1, -1 ) );`
	`90`	`+ int pos = helpPath.lastIndexOf( "#" );`
	`91`	`+ if ( pos != -1 )`
	`92`	`+ {`
	`93`	`+ helpUrl.setFragment( helpPath.mid( helpPath.lastIndexOf( "#" ) + 1, -1 ) );`
	`94`	`+ }`
`91`	`95`	`}`
`92`	`96`
`93`	`97`	`helpFound = true;`