Skip to content

Commit eab09f0

Browse files
committed
Bring back QgsNetworkManager slots and signals removed in 2eb8243 as deprecated
(cherry picked from commit 78725fe)
1 parent 2572d18 commit eab09f0

File tree

3 files changed

+57
-0
lines changed

3 files changed

+57
-0
lines changed

python/core/qgsnetworkaccessmanager.sip

+20
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,32 @@ class QgsNetworkAccessManager : QNetworkAccessManager
6060
//! Setup the NAM according to the user's settings
6161
void setupDefaultProxyAndCache();
6262

63+
//! return whether the system proxy should be used
6364
bool useSystemProxy();
6465

66+
public slots:
67+
/** Send GET request, calls get().
68+
* Emits requestSent().
69+
* @param request request to be sent
70+
* @deprecated use get() directly
71+
*/
72+
void sendGet( const QNetworkRequest & request ) /Deprecated/;
73+
/** Abort and delete reply.
74+
* @param reply reply to be aborted.
75+
* @deprecated use abort() and deleteLayer() on the reply directly
76+
*/
77+
void deleteReply( QNetworkReply * reply ) /Deprecated/;
78+
6579
signals:
6680
void requestAboutToBeCreated( QNetworkAccessManager::Operation, const QNetworkRequest &, QIODevice * );
6781
void requestCreated( QNetworkReply * );
6882
void requestTimedOut( QNetworkReply * );
83+
/** Emitted when request was sent by request()
84+
* @param reply request reply
85+
* @param sender the object which called request() slot.
86+
* @deprecated only emitted from deprecated sendGet
87+
*/
88+
void requestSent( QNetworkReply * reply, QObject *sender );
6989

7090
protected:
7191
virtual QNetworkReply *createRequest( QNetworkAccessManager::Operation op, const QNetworkRequest &req, QIODevice *outgoingData = 0 );

src/core/qgsnetworkaccessmanager.cpp

+18
Original file line numberDiff line numberDiff line change
@@ -384,3 +384,21 @@ void QgsNetworkAccessManager::setupDefaultProxyAndCache()
384384
if ( cache() != newcache )
385385
setCache( newcache );
386386
}
387+
388+
void QgsNetworkAccessManager::sendGet( const QNetworkRequest & request )
389+
{
390+
QgsDebugMsg( "Entered" );
391+
QNetworkReply * reply = get( request );
392+
emit requestSent( reply, QObject::sender() );
393+
}
394+
395+
void QgsNetworkAccessManager::deleteReply( QNetworkReply * reply )
396+
{
397+
QgsDebugMsg( "Entered" );
398+
if ( !reply )
399+
{
400+
return;
401+
}
402+
reply->abort();
403+
reply->deleteLater();
404+
}

src/core/qgsnetworkaccessmanager.h

+19
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,29 @@ class CORE_EXPORT QgsNetworkAccessManager : public QNetworkAccessManager
8585
//! return whether the system proxy should be used
8686
bool useSystemProxy() { return mUseSystemProxy; }
8787

88+
public slots:
89+
/** Send GET request, calls get().
90+
* Emits requestSent().
91+
* @param request request to be sent
92+
* @deprecated use get() directly
93+
*/
94+
Q_DECL_DEPRECATED void sendGet( const QNetworkRequest & request );
95+
/** Abort and delete reply.
96+
* @param reply reply to be aborted.
97+
* @deprecated use abort() and deleteLayer() on the reply directly
98+
*/
99+
Q_DECL_DEPRECATED void deleteReply( QNetworkReply * reply );
100+
88101
signals:
89102
void requestAboutToBeCreated( QNetworkAccessManager::Operation, const QNetworkRequest &, QIODevice * );
90103
void requestCreated( QNetworkReply * );
91104
void requestTimedOut( QNetworkReply * );
105+
/** Emitted when request was sent by request()
106+
* @param reply request reply
107+
* @param sender the object which called request() slot.
108+
* @deprecated only emitted from deprecated sendGet
109+
*/
110+
void requestSent( QNetworkReply * reply, QObject *sender );
92111

93112
private slots:
94113
void abortRequest();

0 commit comments

Comments
 (0)