Greetings from Anita and Tim at the QGIS Hackfest in Vienna (Nov 2009…

…). We have just fixed bug #2011 (Crash using Identify Feature)...Wheeeeee git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@11927 c8812cc2-4d05-0410-92ff-de0c093fc19c
qgis · Nov 6, 2009 · eb29dc2 · eb29dc2
1 parent fbeef37
commit eb29dc2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/app/qgsmaptoolidentify.cpp b/src/app/qgsmaptoolidentify.cpp
@@ -72,6 +72,10 @@ void QgsMapToolIdentify::canvasReleaseEvent( QMouseEvent * e )
     return;
   }
 
+  if ( !mResults )
+  {
+    mResults = new QgsIdentifyResults( mCanvas, mCanvas->window() );
+  }
   mResults->clear();
 
   QSettings settings;
@@ -147,6 +151,10 @@ void QgsMapToolIdentify::canvasReleaseEvent( QMouseEvent * e )
 
 void QgsMapToolIdentify::activate()
 {
+  if ( !mResults ) 
+  {
+    mResults = new QgsIdentifyResults( mCanvas, mCanvas->window() );
+  }
   mResults->activate();
   QgsMapTool::activate();
 }

diff --git a/src/app/qgsmaptoolidentify.h b/src/app/qgsmaptoolidentify.h
@@ -24,6 +24,7 @@
 #include "qgsdistancearea.h"
 
 #include <QObject>
+#include <QPointer>
 
 class QgsIdentifyResults;
 class QgsMapLayer;
@@ -71,7 +72,7 @@ class QgsMapToolIdentify : public QgsMapTool
     bool identifyVectorLayer( QgsVectorLayer *layer, int x, int y );
 
     //! Pointer to the identify results dialog for name/value pairs
-    QgsIdentifyResults *mResults;
+    QPointer<QgsIdentifyResults> mResults;
 
     //! Private helper
     void convertMeasurement( QgsDistanceArea &calc, double &measure, QGis::UnitType &u, bool isArea );