DB manager fix add comment while creating table

Fixes #38394
qgis · Sep 25, 2020 · eb3c78d · eb3c78d
1 parent 04ae0ca
commit eb3c78d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/python/plugins/db_manager/db_plugins/data_model.py b/python/plugins/db_manager/db_plugins/data_model.py
@@ -301,7 +301,7 @@ def getObject(self, row):
 
         fld.notNull = self.data(self.index(row, 2), Qt.CheckStateRole) == Qt.Unchecked
         fld.primaryKey = self.data(self.index(row, 1), Qt.UserRole)
-        fld.comment = self.data(self.index(row, 4), Qt.UserRole)
+        fld.comment = self.data(self.index(row, 4))
         return fld
 
     def getFields(self):

diff --git a/python/plugins/db_manager/db_plugins/plugin.py b/python/plugins/db_manager/db_plugins/plugin.py
@@ -585,6 +585,13 @@ def createTable(self, table, fields, schema=None):
 
         ret = self.connector.createTable((schema, table), field_defs, pk_name)
         if ret is not False:
+            # Add comments if any, because definition does not include
+            # the comment
+            for f in fields:
+                if f.comment:
+                    self.connector.updateTableColumn(
+                        (schema, table), f.name, comment=f.comment
+                    )
             self.refresh()
         return ret