Avoid insertion of null pointers in layer registry

qgis · Dec 8, 2015 · ec20db7 · ec20db7
1 parent 269f709
commit ec20db7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/core/qgsmaplayerregistry.cpp b/src/core/qgsmaplayerregistry.cpp
@@ -119,7 +119,7 @@ void QgsMapLayerRegistry::removeMapLayers( const QStringList& theLayerIds )
   QList<QgsMapLayer*> layers;
   Q_FOREACH ( const QString &myId, theLayerIds )
   {
-    layers << mMapLayers[myId];
+    layers << mMapLayers.value( myId );
   }
 
   removeMapLayers( layers );
@@ -160,12 +160,13 @@ void QgsMapLayerRegistry::removeMapLayers( const QList<QgsMapLayer*>& layers )
 
 void QgsMapLayerRegistry::removeMapLayer( const QString& theLayerId )
 {
-  removeMapLayers( QList<QgsMapLayer*>() << mMapLayers[theLayerId] );
+  removeMapLayers( QList<QgsMapLayer*>() << mMapLayers.value( theLayerId ) );
 }
 
 void QgsMapLayerRegistry::removeMapLayer( QgsMapLayer* layer )
 {
-  removeMapLayers( QList<QgsMapLayer*>() << layer );
+  if ( layer )
+    removeMapLayers( QList<QgsMapLayer*>() << layer );
 }
 
 void QgsMapLayerRegistry::removeAllMapLayers()

diff --git a/tests/src/python/test_qgsmaplayerregistry.py b/tests/src/python/test_qgsmaplayerregistry.py
@@ -25,6 +25,11 @@ def test_RemoveLayerShouldNotSegFault(self):
         reg = QgsMapLayerRegistry.instance()
         # Should not segfault
         reg.removeMapLayers(['not_exists'])
+        reg.removeMapLayer('not_exists2')
+
+        # check also that the removal of an unexistant layer does not insert a null layer
+        for k, layer in reg.mapLayers().items():
+            assert(layer is not None)
 
 
 if __name__ == '__main__':