Fix regression in raster psuedo ramp rendering when only two classes exist

nyalldawson · nyalldawson · commit edec245be2f2 · 2018-08-02T07:21:17.000+10:00
diff --git a/src/core/raster/qgscolorrampshader.cpp b/src/core/raster/qgscolorrampshader.cpp
@@ -359,9 +359,6 @@ bool QgsColorRampShader::shade( double value, int *returnRedValue, int *returnGr
     mLUTInitialized = true;
   }
 
-  if ( mLUT.empty() )
-    return false;
-
   // overflow indicates that value > maximum value + DOUBLE_DIFF_THRESHOLD
   // that way idx can point to the last valid item
   bool overflow = false;
@@ -380,6 +377,10 @@ bool QgsColorRampShader::shade( double value, int *returnRedValue, int *returnGr
       overflow = true;
     }
   }
+  else if ( lutIndex < 0 )
+  {
+    return false;
+  }
   else
   {
     // get initial value from LUT

Original file line number	Diff line number	Diff line change
`@@ -359,9 +359,6 @@ bool QgsColorRampShader::shade( double value, int returnRedValue, int returnGr`
`359`	`359`	`mLUTInitialized = true;`
`360`	`360`	`}`
`361`	`361`
`362`		`- if ( mLUT.empty() )`
`363`		`- return false;`
`364`		`-`
`365`	`362`	`// overflow indicates that value > maximum value + DOUBLE_DIFF_THRESHOLD`
`366`	`363`	`// that way idx can point to the last valid item`
`367`	`364`	`bool overflow = false;`
`@@ -380,6 +377,10 @@ bool QgsColorRampShader::shade( double value, int returnRedValue, int returnGr`
`380`	`377`	`overflow = true;`
`381`	`378`	`}`
`382`	`379`	`}`
	`380`	`+ else if ( lutIndex < 0 )`
	`381`	`+ {`
	`382`	`+ return false;`
	`383`	`+ }`
`383`	`384`	`else`
`384`	`385`	`{`
`385`	`386`	`// get initial value from LUT`