Permalink
Loading
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Change size()/count() == 0 and count() > 0 to isEmpty() checks
Because: - easier to read - follows recommendations by clazy/KDAB - potentially performance benefits
- Loading branch information
Showing
with
489 additions
and 489 deletions.
- +4 −4 src/analysis/interpolation/DualEdgeTriangulation.cc
- +1 −1 src/analysis/interpolation/NormVecDecorator.cc
- +1 −1 src/analysis/raster/qgsrelief.cpp
- +3 −3 src/app/composer/qgscomposer.cpp
- +1 −1 src/app/composer/qgscomposermanager.cpp
- +1 −1 src/app/composer/qgscomposermapwidget.cpp
- +1 −1 src/app/legend/qgsapplegendinterface.cpp
- +3 −3 src/app/nodetool/qgsmaptoolnodetool.cpp
- +1 −1 src/app/ogr/qgsopenvectorlayerdialog.cpp
- +25 −25 src/app/qgisapp.cpp
- +1 −1 src/app/qgsaddtaborgroup.cpp
- +1 −1 src/app/qgsbookmarks.cpp
- +1 −1 src/app/qgsbrowserdockwidget.cpp
- +1 −1 src/app/qgsconfigureshortcutsdialog.cpp
- +1 −1 src/app/qgsdiagramproperties.cpp
- +5 −5 src/app/qgsfieldsproperties.cpp
- +1 −1 src/app/qgshandlebadlayers.cpp
- +4 −4 src/app/qgsidentifyresultsdialog.cpp
- +1 −1 src/app/qgsjoindialog.cpp
- +1 −1 src/app/qgsmaptoolchangelabelproperties.cpp
- +2 −2 src/app/qgsmaptoolcircularstringradius.cpp
- +2 −2 src/app/qgsmaptoolfeatureaction.cpp
- +2 −2 src/app/qgsnewspatialitelayerdialog.cpp
- +1 −1 src/app/qgsoptions.cpp
- +6 −6 src/app/qgsprojectproperties.cpp
- +1 −1 src/app/qgsrasterlayerproperties.cpp
- +1 −1 src/core/auth/qgsauthcertutils.cpp
- +5 −5 src/core/composer/qgsatlascomposition.cpp
- +4 −4 src/core/composer/qgscomposerarrow.cpp
- +2 −2 src/core/composer/qgscomposerattributetable.cpp
- +3 −3 src/core/composer/qgscomposeritem.cpp
- +1 −1 src/core/composer/qgscomposeritemgroup.cpp
- +2 −2 src/core/composer/qgscomposerlabel.cpp
- +2 −2 src/core/composer/qgscomposerlegend.cpp
- +7 −7 src/core/composer/qgscomposermap.cpp
- +2 −2 src/core/composer/qgscomposermapgrid.cpp
- +4 −4 src/core/composer/qgscomposermousehandles.cpp
- +1 −1 src/core/composer/qgscomposermultiframe.cpp
- +1 −1 src/core/composer/qgscomposerpicture.cpp
- +5 −5 src/core/composer/qgscomposerscalebar.cpp
- +3 −3 src/core/composer/qgscomposershape.cpp
- +2 −2 src/core/composer/qgscomposertable.cpp
- +1 −1 src/core/composer/qgscomposertablecolumn.cpp
- +3 −3 src/core/composer/qgscomposertablev2.cpp
- +1 −1 src/core/composer/qgscomposerutils.cpp
- +2 −2 src/core/composer/qgscomposition.cpp
- +1 −1 src/core/composer/qgslegendmodel.cpp
- +1 −1 src/core/composer/qgspaperitem.cpp
- +2 −2 src/core/diagram/qgshistogramdiagram.cpp
- +1 −1 src/core/dxf/qgsdxfexport.cpp
- +2 −2 src/core/dxf/qgsdxfpaintengine.cpp
- +3 −3 src/core/geometry/qgscompoundcurvev2.cpp
- +2 −2 src/core/geometry/qgsgeos.cpp
- +2 −2 src/core/layertree/qgslayertreegroup.cpp
- +2 −2 src/core/layertree/qgslayertreemodel.cpp
- +1 −1 src/core/layertree/qgslayertreenode.cpp
- +3 −3 src/core/pal/feature.cpp
- +2 −2 src/core/pal/layer.cpp
- +2 −2 src/core/pal/pal.cpp
- +1 −1 src/core/pal/pointset.cpp
- +10 −10 src/core/pal/problem.cpp
- +1 −1 src/core/pal/util.cpp
- +3 −3 src/core/qgsapplication.cpp
- +1 −1 src/core/qgsclipper.cpp
- +4 −4 src/core/qgsdataitem.cpp
- +5 −5 src/core/qgsexpression.cpp
- +1 −1 src/core/qgsfontutils.cpp
- +3 −3 src/core/qgsgml.cpp
- +2 −2 src/core/qgsgmlschema.cpp
- +3 −3 src/core/qgslegendrenderer.cpp
- +1 −1 src/core/qgsmaplayer.cpp
- +2 −2 src/core/qgsmaplayerlegend.cpp
- +1 −1 src/core/qgsmaplayerregistry.cpp
- +1 −1 src/core/qgsmultirenderchecker.cpp
- +2 −2 src/core/qgsnetworkaccessmanager.cpp
- +1 −1 src/core/qgsnetworkreplyparser.cpp
- +9 −9 src/core/qgsogcutils.cpp
- +4 −4 src/core/qgsproject.cpp
- +1 −1 src/core/qgsprojectfiletransform.cpp
- +8 −8 src/core/qgsvectorlayer.cpp
- +1 −1 src/core/qgsvectorlayerdiagramprovider.cpp
- +2 −2 src/core/qgsvectorlayereditutils.cpp
- +1 −1 src/core/qgsvectorlayerfeatureiterator.cpp
- +1 −1 src/core/qgsvectorlayerjoinbuffer.cpp
- +1 −1 src/core/raster/qgsrasterfilewriter.cpp
- +2 −2 src/core/raster/qgsrasterinterface.cpp
- +1 −1 src/core/raster/qgsrasterlayer.cpp
- +2 −2 src/core/raster/qgsrastertransparency.cpp
- +2 −2 src/core/symbology-ng/qgscategorizedsymbolrendererv2.cpp
- +4 −4 src/core/symbology-ng/qgscptcityarchive.cpp
- +5 −5 src/core/symbology-ng/qgsgraduatedsymbolrendererv2.cpp
- +1 −1 src/core/symbology-ng/qgslinesymbollayerv2.cpp
- +2 −2 src/core/symbology-ng/qgsrendererv2.cpp
- +5 −5 src/core/symbology-ng/qgsrulebasedrendererv2.cpp
- +2 −2 src/core/symbology-ng/qgssinglesymbolrendererv2.cpp
- +5 −5 src/core/symbology-ng/qgssymbollayerv2utils.cpp
- +3 −3 src/core/symbology-ng/qgssymbolv2.cpp
- +1 −1 src/gui/attributetable/qgsattributetableview.cpp
- +3 −3 src/gui/attributetable/qgsdualview.cpp
- +1 −1 src/gui/attributetable/qgsfieldconditionalformatwidget.cpp
- +1 −1 src/gui/auth/qgsauthauthoritieseditor.cpp
- +1 −1 src/gui/auth/qgsauthconfigidedit.cpp
- +2 −2 src/gui/auth/qgsauthimportcertdialog.cpp
- +3 −3 src/gui/editorwidgets/qgsdoublespinbox.cpp
- +1 −1 src/gui/editorwidgets/qgsenumerationwidgetfactory.cpp
- +2 −2 src/gui/editorwidgets/qgsrelationreferencewidget.cpp
- +3 −3 src/gui/editorwidgets/qgsspinbox.cpp
- +1 −1 src/gui/layertree/qgslayertreemapcanvasbridge.cpp
- +1 −1 src/gui/qgsactionmenu.cpp
- +1 −1 src/gui/qgsattributedialog.cpp
- +1 −1 src/gui/qgsattributeform.cpp
- +2 −2 src/gui/qgscolorswatchgrid.cpp
- +8 −8 src/gui/qgscomposerview.cpp
- +1 −1 src/gui/qgsdatadefinedbutton.cpp
- +1 −1 src/gui/qgsexpressionbuilderwidget.cpp
- +2 −2 src/gui/qgsfieldvalidator.cpp
- +7 −7 src/gui/qgshistogramwidget.cpp
- +6 −6 src/gui/qgsidentifymenu.cpp
- +1 −1 src/gui/qgsmapcanvas.cpp
- +1 −1 src/gui/qgsmaplayermodel.cpp
- +1 −1 src/gui/qgsmaptoolcapture.cpp
- +4 −4 src/gui/qgsmessagebar.cpp
- +1 −1 src/gui/qgsnewnamedialog.cpp
- +2 −2 src/gui/qgsnewvectorlayerdialog.cpp
- +1 −1 src/gui/qgsowssourceselect.cpp
- +6 −6 src/gui/qgsprojectionselector.cpp
- +1 −1 src/gui/qgsrasterformatsaveoptionswidget.cpp
- +4 −4 src/gui/qgsrubberband.cpp
- +1 −1 src/gui/raster/qgssinglebandpseudocolorrendererwidget.cpp
- +6 −6 src/gui/symbology-ng/qgscategorizedsymbolrendererv2widget.cpp
- +1 −1 src/gui/symbology-ng/qgscptcitycolorrampv2dialog.cpp
- +1 −1 src/gui/symbology-ng/qgsellipsesymbollayerv2widget.cpp
- +4 −4 src/gui/symbology-ng/qgsgraduatedsymbolrendererv2widget.cpp
- +1 −1 src/gui/symbology-ng/qgsrendererv2widget.h
- +1 −1 src/gui/symbology-ng/qgssmartgroupeditordialog.cpp
- +2 −2 src/gui/symbology-ng/qgsstylev2managerdialog.cpp
- +2 −2 src/plugins/dxf2shp_converter/builder.cpp
- +1 −1 src/plugins/evis/databaseconnection/evisdatabaseconnectiongui.cpp
- +2 −2 src/plugins/evis/eventbrowser/evisgenericeventbrowsergui.cpp
- +1 −1 src/plugins/evis/evis.cpp
- +4 −4 src/plugins/geometry_checker/ui/qgsgeometrycheckerfixsummarydialog.cpp
- +1 −1 src/plugins/georeferencer/qgsgcpcanvasitem.cpp
- +1 −1 src/plugins/georeferencer/qgsgeorefplugingui.cpp
- +2 −2 src/plugins/spatialquery/qgsspatialquery.cpp
- +3 −3 src/plugins/spatialquery/qgsspatialquerydialog.cpp
- +1 −1 src/plugins/topology/topolTest.cpp
- +2 −2 src/providers/delimitedtext/qgsdelimitedtextfile.cpp
- +2 −2 src/providers/delimitedtext/qgsdelimitedtextprovider.cpp
- +2 −2 src/providers/delimitedtext/qgsdelimitedtextsourceselect.cpp
- +2 −2 src/providers/gdal/qgsgdaldataitems.cpp
- +11 −11 src/providers/gdal/qgsgdalprovider.cpp
- +2 −2 src/providers/gpx/qgsgpxfeatureiterator.cpp
- +1 −1 src/providers/memory/qgsmemoryprovider.cpp
- +1 −1 src/providers/mssql/qgsmssqldataitems.cpp
- +2 −2 src/providers/mssql/qgsmssqlprovider.cpp
- +1 −1 src/providers/mssql/qgsmssqlsourceselect.cpp
- +3 −3 src/providers/mssql/qgsmssqltablemodel.cpp
- +2 −2 src/providers/ogr/qgsogrprovider.cpp
- +1 −1 src/providers/postgres/qgspgsourceselect.cpp
- +4 −4 src/providers/postgres/qgspgtablemodel.cpp
- +1 −1 src/providers/postgres/qgspostgresdataitems.cpp
- +3 −3 src/providers/postgres/qgspostgresprovider.cpp
- +2 −2 src/providers/spatialite/qgsspatialiteprovider.cpp
- +1 −1 src/providers/spatialite/qgsspatialitetablemodel.cpp
- +5 −5 src/providers/wcs/qgswcscapabilities.cpp
- +2 −2 src/providers/wcs/qgswcsdataitems.cpp
- +2 −2 src/providers/wcs/qgswcsprovider.cpp
- +1 −1 src/providers/wcs/qgswcssourceselect.cpp
- +1 −1 src/providers/wfs/qgswfssourceselect.cpp
- +2 −2 src/providers/wms/qgstilescalewidget.cpp
- +4 −4 src/providers/wms/qgswmsdataitems.cpp
- +10 −10 src/providers/wms/qgswmsprovider.cpp
- +2 −2 src/providers/wms/qgswmssourceselect.cpp
- +2 −2 src/server/qgsconfigparserutils.cpp
- +1 −1 src/server/qgshttprequesthandler.cpp
- +1 −1 src/server/qgsinterpolationlayerbuilder.cpp
- +2 −2 src/server/qgsremoteowsbuilder.cpp
- +1 −1 src/server/qgsserverprojectparser.cpp
- +17 −17 src/server/qgssldconfigparser.cpp
- +16 −16 src/server/qgssoaprequesthandler.cpp
- +7 −7 src/server/qgswfsserver.cpp
- +2 −2 src/server/qgswmsprojectparser.cpp
- +3 −3 src/server/qgswmsserver.cpp
- +1 −1 tests/src/core/testqgsrulebasedrenderer.cpp
- +1 −1 tests/src/core/testqgsvectorlayerjoinbuffer.cpp
- +1 −1 tests/src/core/testziplayer.cpp
- +4 −4 tests/src/providers/testqgswcspublicservers.cpp
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,7 @@ | ||
| NormVecDecorator::~NormVecDecorator() | ||
| { | ||
| //remove all the normals | ||
| if ( !mNormVec->isEmpty() ) | ||
| { | ||
| for ( int i = 0; i < mNormVec->count(); i++ ) | ||
| { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -181,7 +181,7 @@ void QgsBookmarks::deleteClicked() | ||
| } | ||
| } | ||
|
|
||
| if ( rows.isEmpty() ) | ||
| return; | ||
|
|
||
| // make sure the user really wants to delete these bookmarks | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -421,7 +421,7 @@ void QgsBrowserDockWidget::showContextMenu( const QPoint & pt ) | ||
| menu->addActions( actions ); | ||
| } | ||
|
|
||
| if ( menu->actions().isEmpty() ) | ||
| { | ||
| delete menu; | ||
| return; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.