Use unique_ptr

qgis · Sep 6, 2017 · eee7577 · eee7577
1 parent 37b6052
commit eee7577
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/src/app/qgsmaptoolcircle3points.cpp b/src/app/qgsmaptoolcircle3points.cpp
@@ -68,10 +68,10 @@ void QgsMapToolCircle3Points::cadCanvasMoveEvent( QgsMapMouseEvent *e )
     {
       case 1:
       {
-        QgsLineString *line = new QgsLineString();
+        std::unique_ptr<QgsLineString> line( new QgsLineString() );
         line->addVertex( mPoints.at( 0 ) );
         line->addVertex( mapPoint );
-        mTempRubberBand->setGeometry( line );
+        mTempRubberBand->setGeometry( line.release() );
       }
       break;
       case 2:

diff --git a/src/app/qgsmaptoolellipsecenter2points.cpp b/src/app/qgsmaptoolellipsecenter2points.cpp
@@ -19,6 +19,7 @@
 #include "qgsmapcanvas.h"
 #include "qgspoint.h"
 #include <QMouseEvent>
+#include <memory>
 
 QgsMapToolEllipseCenter2Points::QgsMapToolEllipseCenter2Points( QgsMapToolCapture *parentTool,
     QgsMapCanvas *canvas, CaptureMode mode )
@@ -69,10 +70,10 @@ void QgsMapToolEllipseCenter2Points::cadCanvasMoveEvent( QgsMapMouseEvent *e )
     {
       case 1:
       {
-        QgsLineString *line = new QgsLineString();
+        std::unique_ptr<QgsLineString> line( new QgsLineString() );
         line->addVertex( mPoints.at( 0 ) );
         line->addVertex( mapPoint );
-        mTempRubberBand->setGeometry( line );
+        mTempRubberBand->setGeometry( line.release() );
       }
       break;
       case 2:

diff --git a/src/app/qgsmaptoolellipsefoci.cpp b/src/app/qgsmaptoolellipsefoci.cpp
@@ -19,6 +19,7 @@
 #include "qgsmapcanvas.h"
 #include "qgspoint.h"
 #include <QMouseEvent>
+#include <memory>
 
 QgsMapToolEllipseFoci::QgsMapToolEllipseFoci( QgsMapToolCapture *parentTool,
     QgsMapCanvas *canvas, CaptureMode mode )
@@ -67,10 +68,10 @@ void QgsMapToolEllipseFoci::cadCanvasMoveEvent( QgsMapMouseEvent *e )
     {
       case 1:
       {
-        QgsLineString *line = new QgsLineString();
+        std::unique_ptr<QgsLineString> line( new QgsLineString() );
         line->addVertex( mPoints.at( 0 ) );
         line->addVertex( mapPoint );
-        mTempRubberBand->setGeometry( line );
+        mTempRubberBand->setGeometry( line.release() );
       }
       break;
       case 2:

diff --git a/src/app/qgsmaptoolrectangle3points.cpp b/src/app/qgsmaptoolrectangle3points.cpp
@@ -70,10 +70,10 @@ void QgsMapToolRectangle3Points::cadCanvasMoveEvent( QgsMapMouseEvent *e )
     {
       case 1:
       {
-        QgsLineString *line = new QgsLineString();
+        std::unique_ptr<QgsLineString> line( new QgsLineString() );
         line->addVertex( mPoints.at( 0 ) );
         line->addVertex( mapPoint );
-        mTempRubberBand->setGeometry( line );
+        mTempRubberBand->setGeometry( line.release() );
         setAzimuth( mPoints.at( 0 ).azimuth( mapPoint ) );
         setDistance1( mPoints.at( 0 ).distance( mapPoint ) );
       }