Skip to content

Commit

Permalink
[auth] Keep sensitive debug data commented out
Browse files Browse the repository at this point in the history
  • Loading branch information
dakcarto committed Oct 26, 2017
1 parent a1efff7 commit ef7a29d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/core/auth/qgsauthcertutils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -413,8 +413,8 @@ QByteArray QgsAuthCertUtils::pkcs8PrivateKey( QByteArray &pkcs8Der )

pkcs1 = QByteArray( oct_data, oct_len );

// !!! SENSITIVE DATA !!!
QgsDebugMsgLevel( QStringLiteral( "privateKey octet data as PEM: %1" ).arg( QString( pkcs1.toBase64() ) ), 9 );
// !!! SENSITIVE DATA - DO NOT LEAVE UNCOMMENTED !!!
//QgsDebugMsgLevel( QStringLiteral( "privateKey octet data as PEM: %1" ).arg( QString( pkcs1.toBase64() ) ), 4 );

PKCS1DONE:

Expand Down Expand Up @@ -512,8 +512,8 @@ QStringList QgsAuthCertUtils::pkcs12BundleToPem( const QString &bundlepath,
#endif

QgsDebugMsgLevel( QString( "PKCS#12 cert as PEM:\n%1" ).arg( QString( bundle.certificateChain().primary().toPEM() ) ), 4 );
// !!! SENSITIVE DATA !!!
QgsDebugMsgLevel( QString( "PKCS#12 key as PEM:\n%1" ).arg( QString( keyPem ) ), 9 );
// !!! SENSITIVE DATA - DO NOT LEAVE UNCOMMENTED !!!
//QgsDebugMsgLevel( QString( "PKCS#12 key as PEM:\n%1" ).arg( QString( keyPem ) ), 4 );

return QStringList() << bundle.certificateChain().primary().toPEM() << keyPem << algtype;
}
Expand Down

0 comments on commit ef7a29d

Please sign in to comment.