diff --git a/src/app/qgsmaptoolcircle2points.cpp b/src/app/qgsmaptoolcircle2points.cpp index ce72bc077de9..31008163e964 100644 --- a/src/app/qgsmaptoolcircle2points.cpp +++ b/src/app/qgsmaptoolcircle2points.cpp @@ -34,10 +34,10 @@ void QgsMapToolCircle2Points::cadCanvasReleaseEvent( QgsMapMouseEvent *e ) if ( e->button() == Qt::LeftButton ) { - if ( mPoints.size() < 1 ) + if ( mPoints.isEmpty() ) mPoints.append( point ); - if ( !mPoints.isEmpty() && !mTempRubberBand ) + if ( !mTempRubberBand ) { mTempRubberBand = createGeometryRubberBand( mLayerType, true ); mTempRubberBand->show(); diff --git a/src/app/qgsmaptoolcirclecenterpoint.cpp b/src/app/qgsmaptoolcirclecenterpoint.cpp index d9b429c707e4..a7772d473da0 100644 --- a/src/app/qgsmaptoolcirclecenterpoint.cpp +++ b/src/app/qgsmaptoolcirclecenterpoint.cpp @@ -34,10 +34,10 @@ void QgsMapToolCircleCenterPoint::cadCanvasReleaseEvent( QgsMapMouseEvent *e ) if ( e->button() == Qt::LeftButton ) { - if ( mPoints.size() < 1 ) + if ( mPoints.empty() ) mPoints.append( point ); - if ( !mPoints.isEmpty() && !mTempRubberBand ) + if ( !mTempRubberBand ) { mTempRubberBand = createGeometryRubberBand( mLayerType, true ); mTempRubberBand->show(); diff --git a/src/app/qgsmaptoolellipsecenterpoint.cpp b/src/app/qgsmaptoolellipsecenterpoint.cpp index 5cdbcab202a3..7bb79643c07b 100644 --- a/src/app/qgsmaptoolellipsecenterpoint.cpp +++ b/src/app/qgsmaptoolellipsecenterpoint.cpp @@ -34,10 +34,10 @@ void QgsMapToolEllipseCenterPoint::cadCanvasReleaseEvent( QgsMapMouseEvent *e ) if ( e->button() == Qt::LeftButton ) { - if ( mPoints.size() < 1 ) + if ( mPoints.empty() ) mPoints.append( point ); - if ( !mPoints.isEmpty() && !mTempRubberBand ) + if ( !mTempRubberBand ) { mTempRubberBand = createGeometryRubberBand( mLayerType, true ); mTempRubberBand->show(); diff --git a/src/app/qgsmaptoolellipseextent.cpp b/src/app/qgsmaptoolellipseextent.cpp index 1f1274923c54..a3367daad989 100644 --- a/src/app/qgsmaptoolellipseextent.cpp +++ b/src/app/qgsmaptoolellipseextent.cpp @@ -36,10 +36,10 @@ void QgsMapToolEllipseExtent::cadCanvasReleaseEvent( QgsMapMouseEvent *e ) if ( e->button() == Qt::LeftButton ) { - if ( mPoints.size() < 1 ) + if ( mPoints.empty() ) mPoints.append( point ); - if ( !mPoints.isEmpty() && !mTempRubberBand ) + if ( !mTempRubberBand ) { mTempRubberBand = createGeometryRubberBand( mLayerType, true ); mTempRubberBand->show(); diff --git a/src/app/qgsmaptoolellipsefoci.cpp b/src/app/qgsmaptoolellipsefoci.cpp index 36d054f18c74..71b1b466a638 100644 --- a/src/app/qgsmaptoolellipsefoci.cpp +++ b/src/app/qgsmaptoolellipsefoci.cpp @@ -38,7 +38,7 @@ void QgsMapToolEllipseFoci::cadCanvasReleaseEvent( QgsMapMouseEvent *e ) if ( mPoints.size() < 2 ) mPoints.append( point ); - if ( !mPoints.isEmpty() && !mTempRubberBand ) + if ( !mTempRubberBand ) { mTempRubberBand = createGeometryRubberBand( mLayerType, true ); mTempRubberBand->show(); diff --git a/src/app/qgsmaptoolrectanglecenter.cpp b/src/app/qgsmaptoolrectanglecenter.cpp index dd1ef59b73f8..368c3b10623c 100644 --- a/src/app/qgsmaptoolrectanglecenter.cpp +++ b/src/app/qgsmaptoolrectanglecenter.cpp @@ -38,10 +38,10 @@ void QgsMapToolRectangleCenter::cadCanvasReleaseEvent( QgsMapMouseEvent *e ) if ( e->button() == Qt::LeftButton ) { - if ( mPoints.size() < 1 ) + if ( mPoints.empty() ) mPoints.append( point ); - if ( !mPoints.isEmpty() && !mTempRubberBand ) + if ( !mTempRubberBand ) { mTempRubberBand = createGeometryRubberBand( mLayerType, true ); mTempRubberBand->show(); diff --git a/src/app/qgsmaptoolrectangleextent.cpp b/src/app/qgsmaptoolrectangleextent.cpp index 60dd78498efe..6cde94687fe8 100644 --- a/src/app/qgsmaptoolrectangleextent.cpp +++ b/src/app/qgsmaptoolrectangleextent.cpp @@ -36,10 +36,10 @@ void QgsMapToolRectangleExtent::cadCanvasReleaseEvent( QgsMapMouseEvent *e ) if ( e->button() == Qt::LeftButton ) { - if ( mPoints.size() < 1 ) + if ( mPoints.empty() ) mPoints.append( point ); - if ( !mPoints.isEmpty() && !mTempRubberBand ) + if ( !mTempRubberBand ) { mTempRubberBand = createGeometryRubberBand( mLayerType, true ); mTempRubberBand->show(); diff --git a/src/app/qgsmaptoolregularpolygon2points.cpp b/src/app/qgsmaptoolregularpolygon2points.cpp index 0bb49f4a0786..d96f9d6930ff 100644 --- a/src/app/qgsmaptoolregularpolygon2points.cpp +++ b/src/app/qgsmaptoolregularpolygon2points.cpp @@ -41,18 +41,15 @@ void QgsMapToolRegularPolygon2Points::cadCanvasReleaseEvent( QgsMapMouseEvent *e if ( e->button() == Qt::LeftButton ) { - if ( mPoints.size() < 1 ) + if ( mPoints.empty() ) mPoints.append( point ); - if ( !mPoints.isEmpty() ) + if ( !mTempRubberBand ) { - if ( !mTempRubberBand ) - { - mTempRubberBand = createGeometryRubberBand( mLayerType, true ); - mTempRubberBand->show(); + mTempRubberBand = createGeometryRubberBand( mLayerType, true ); + mTempRubberBand->show(); - createNumberSidesSpinBox(); - } + createNumberSidesSpinBox(); } } else if ( e->button() == Qt::RightButton ) diff --git a/src/app/qgsmaptoolregularpolygoncentercorner.cpp b/src/app/qgsmaptoolregularpolygoncentercorner.cpp index d6e87d28d09b..410a9d6b749f 100644 --- a/src/app/qgsmaptoolregularpolygoncentercorner.cpp +++ b/src/app/qgsmaptoolregularpolygoncentercorner.cpp @@ -39,18 +39,15 @@ void QgsMapToolRegularPolygonCenterCorner::cadCanvasReleaseEvent( QgsMapMouseEve if ( e->button() == Qt::LeftButton ) { - if ( mPoints.size() < 1 ) + if ( mPoints.empty() ) mPoints.append( point ); - if ( !mPoints.isEmpty() ) + if ( !mTempRubberBand ) { - if ( !mTempRubberBand ) - { - mTempRubberBand = createGeometryRubberBand( mLayerType, true ); - mTempRubberBand->show(); + mTempRubberBand = createGeometryRubberBand( mLayerType, true ); + mTempRubberBand->show(); - createNumberSidesSpinBox(); - } + createNumberSidesSpinBox(); } } else if ( e->button() == Qt::RightButton )