Skip to content

Commit

Permalink
Remove include "qgsapplication.h" from qgswkbptr.h
Browse files Browse the repository at this point in the history
qgswkbptr.h is included indirectly by a large number of source files.
So this commit does the following:
  - remove #include "qgsapplication.h" from qgswkbptr.h, and copy-paste the swap_endian
    function where it's used.
  - add the missing #include "qgsapplication.h" in other files

The rationale for this change is:
  - qgswkbptr.h doesn't really needs QgsApplication, since it only used swap_endian.
    We don't need to add a fake dependency on QgsApplication on every (indirect) "includers"
    of qgswkbptr.h
 - qgsapplication.h depends on qgsconfig.h which itself changes quite often (on every git op
   at least). Before this change, a 'git commit' would trigger a rebuild of about 3500 files.
   With this change we're down to ~700.
  • Loading branch information
peppsac committed Jan 22, 2019
1 parent 1cd7bde commit f1760ee
Show file tree
Hide file tree
Showing 127 changed files with 142 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@




typedef QVector< QgsPoint > QgsPointSequence;
typedef QVector< QVector< QgsPoint > > QgsRingSequence;
typedef QVector< QVector< QVector< QgsPoint > > > QgsCoordinateSequence;
Expand Down
1 change: 1 addition & 0 deletions python/core/auto_generated/geometry/qgswkbptr.sip.in
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ class QgsConstWkbPtr




public:
QgsConstWkbPtr( const unsigned char *p /Array/, int size /ArraySize/ );

Expand Down
1 change: 1 addition & 0 deletions python/core/auto_generated/qgsabstractcontentcache.sip.in
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@




class QgsAbstractContentCacheEntry
{
%Docstring
Expand Down
1 change: 0 additions & 1 deletion python/core/auto_generated/qgsapplication.sip.in
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,6 @@ Gets application icon
Returns whether this machine uses big or little endian
%End


static QString reportStyleSheet();
%Docstring
Returns a standard css style sheet for reports.
Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmbuffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmcentroid.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmclip.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmconvexhull.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmdifference.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#define SIP_NO_FILE

#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmdissolve.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmextractbylocation.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmextractvertices.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmintersection.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#define SIP_NO_FILE

#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmlineintersection.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmloadlayer.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmmeancoordinates.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmmergevector.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmnetworkanalysisbase.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "qgsgraph.h"
#include "qgsgraphbuilder.h"
#include "qgsvectorlayerdirector.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmpointonsurface.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmpromotetomultipart.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmsimplify.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "qgis.h"
#include "qgsprocessingalgorithm.h"
#include "qgsmaptopixelgeometrysimplifier.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#define SIP_NO_FILE

#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down
1 change: 1 addition & 0 deletions src/analysis/processing/qgsalgorithmunion.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#define SIP_NO_FILE

#include "qgsprocessingalgorithm.h"
#include "qgsapplication.h"

///@cond PRIVATE

Expand Down