Skip to content
Browse files
[processing] Always log python exceptions to logger
Because Python code cannot catch and rethrow c++ exceptions
without losing context, we end up getting unknown exceptions
caught by c++ from python code (phew!).

So if we catch a python exception from processing, throw it
into the log so at least there's the full debugging detail
available on the console.

(Not ideal. Would love to see a PR allowing the full error
message to be passed correctly between c++/python/back again)
  • Loading branch information
nyalldawson committed Apr 3, 2018
1 parent 615cb6c commit f4445a0493465da44ddd6abf4e7ab208ab840a4e
Showing 1 changed file with 2 additions and 0 deletions.

#include "qgsexception.h"
#include "qgslogger.h"

QString getTraceback()
@@ -107,6 +108,7 @@ done:

%VirtualErrorHandler processing_exception_handler
QString trace = getTraceback();
QgsLogger::critical( trace );
throw QgsProcessingException( trace );

0 comments on commit f4445a0

Please sign in to comment.