Skip to content
Permalink
Browse files

[processing] fix wrong variable name in GDAL alggorithms base class

  • Loading branch information
alexbruy committed Feb 24, 2018
1 parent 725f360 commit f638b3cb528a60a17249c354e7cc1e8c2cc3c9d6
Showing with 1 addition and 1 deletion.
  1. +1 −1 python/plugins/processing/algs/gdal/GdalAlgorithm.py
@@ -133,7 +133,7 @@ def helpUrl(self):

def commandName(self):
parameters = {}
for output in self.outputs:
for output in self.outputDefinitions():
output.setValue("dummy")
for param in self.parameterDefinitions():
parameters[param.name()] = "1"

4 comments on commit f638b3c

@ghtmtt

This comment has been minimized.

Copy link
Contributor

@ghtmtt ghtmtt replied Feb 24, 2018

Hi @alexbruy I think you are taking care of https://issues.qgis.org/issues/18198. I re-build QGIS and I still have a stack trace:

Traceback (most recent call last):
  File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/gdal/GdalAlgorithm.py", line 132, in helpUrl
    return helpPath + '{}.html'.format(self.commandName())
  File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/gdal/GdalAlgorithm.py", line 137, in commandName
    output.setValue("dummy")
AttributeError: 'QgsProcessingOutputRasterLayer' object has no attribute 'setValue'

I don't know if other commits are coming and/or comments like this help you. In case just ignore them ;)

Thanks for all this work!

@alexbruy

This comment has been minimized.

Copy link
Contributor Author

@alexbruy alexbruy replied Feb 24, 2018

@ghtmtt thanks for the information. I can't reproduce it (as well as #18198). Looking now.

@alexbruy

This comment has been minimized.

Copy link
Contributor Author

@alexbruy alexbruy replied Feb 24, 2018

@ghtmtt can you try with f3af22e?

@ghtmtt

This comment has been minimized.

Copy link
Contributor

@ghtmtt ghtmtt replied Feb 24, 2018

I get this stack trace:

Traceback (most recent call last):
  File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/gdal/GdalAlgorithm.py", line 132, in helpUrl
    return helpPath + '{}.html'.format(self.commandName())
  File "/home/matteo/lavori/QGIS/build-qgis3/output/python/plugins/processing/algs/gdal/GdalAlgorithm.py", line 137, in commandName
    results[output.name()] = "dummy"
NameError: name 'results' is not defined
Please sign in to comment.
You can’t perform that action at this time.