Skip to content

Commit

Permalink
Fix for msys shell not launching due to spaces in paths / filenames
Browse files Browse the repository at this point in the history
git-svn-id: http://svn.osgeo.org/qgis/trunk@6187 c8812cc2-4d05-0410-92ff-de0c093fc19c
  • Loading branch information
timlinux committed Dec 5, 2006
1 parent 8eae106 commit f8fb769
Showing 1 changed file with 13 additions and 10 deletions.
23 changes: 13 additions & 10 deletions src/plugins/grass/qgsgrasstools.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -211,24 +211,27 @@ void QgsGrassTools::moduleClicked( Q3ListViewItem * item )
// Note: I was not able to run cmd.exe and command.com
// with QProcess

QString msysPath = mAppDir + "/msys/msys.bat";
QString msysPath = mAppDir + "/msys/bin/rxvt.exe";
QString myArguments = "-backspacekey ^H -sl 2500 -fg white -bg black -sr -fn Courier-16 -tn msys -geometry 80x25 -e /bin/sh --login -i";
QFile file ( msysPath );

if ( !file.exists() )
{
QMessageBox::warning( 0, "Warning",
"Cannot find MSYS (" + msysPath + ")" );
QMessageBox::warning( 0, "Warning",
"Cannot find MSYS (" + msysPath + ")" );
}
else
{
QProcess *proc = new QProcess(this);
proc->start (msysPath);
proc->waitForStarted();
if ( proc->state() != QProcess::Running )
{
QMessageBox::warning( 0, "Warning",
QProcess *proc = new QProcess(this);
//allow msys to exist in a path with spaces
msysPath = "\"" + msysPath + "\"" ;
proc->start(msysPath + " " + myArguments);
proc->waitForStarted();
if ( proc->state() != QProcess::Running )
{
QMessageBox::warning( 0, "Warning",
"Cannot start MSYS (" + msysPath + ")" );
}
}
}
return;
#else
Expand Down

0 comments on commit f8fb769

Please sign in to comment.