Skip to content
Permalink
Browse files
Crazy fix to avoid shared data getting corrupted in sip bindings
Without this (should be unnecessary) virtual destructor the
shared data member for QgsProperty gets filled with garbage if
a QgsProperty is created from python code.

I can't explain it...!
  • Loading branch information
nyalldawson committed Jan 23, 2017
1 parent c3617de commit fa26b4573696a2f7983c9d6b6d92c08888b0d120
Showing with 4 additions and 0 deletions.
  1. +2 −0 python/core/qgsproperty.sip
  2. +2 −0 src/core/qgsproperty.h
@@ -76,6 +76,8 @@ class QgsProperty
};

QgsProperty();
virtual ~QgsProperty();

static QgsProperty fromExpression( const QString& expression, bool isActive = true );
static QgsProperty fromField( const QString& fieldName, bool isActive = true );
static QgsProperty fromValue( const QVariant& value, bool isActive = true );
@@ -191,6 +191,8 @@ class CORE_EXPORT QgsProperty
*/
QgsProperty();

virtual ~QgsProperty() = default;

/**
* Returns a new ExpressionBasedProperty created from the specified expression.
*/

0 comments on commit fa26b45

Please sign in to comment.