-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add an assert to protect multiple calls to QgsSymbolV2::startRender()
while rendering has already been started for a particular symbol instance Relates to a random but frequent crash which occurs when using the categorised symbol renderer - tracked down to a race condition in which multiple concurrent calls to startRender() are performed on a single symbol instance.
- Loading branch information
1 parent
67c6e8f
commit fabf32e
Showing
2 changed files
with
10 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabf32e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson , QGIS now crashes when opening a project here:
fabf32e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirvn looks like you've found another place where this crash could occur! Basically what my commit did is force these to be brought to our attention, rather then letting them hide away until random occurrences.
fabf32e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson , I've been able to come up with a small test project that crashes QGIS:
qgis-crash.zip
fabf32e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson , actually, no test project needed. Simply add a polygon dataset, and change its symbology to a line pattern symbol. boom.