Followups

nyalldawson · nyalldawson · commit fb16dab89ff4 · 2018-05-03T11:23:23.000+10:00
(cherry-picked from c3b6990)
diff --git a/src/providers/oracle/qgsoracleprovider.cpp b/src/providers/oracle/qgsoracleprovider.cpp
@@ -1301,7 +1301,7 @@ bool QgsOracleProvider::addFeatures( QgsFeatureList &flist, QgsFeatureSink::Flag
         QVariant value = attributevec[ fieldId[i] ];
 
         QString v;
-        if ( !value.isValid() || value.isNull() )
+        if ( value.isNull() )
         {
           if ( mPrimaryKeyAttrs.contains( i ) && !defaultValues.at( i ).isEmpty() )
           {

Original file line number	Diff line number	Diff line change
`@@ -1301,7 +1301,7 @@ bool QgsOracleProvider::addFeatures( QgsFeatureList &flist, QgsFeatureSink::Flag`
`1301`	`1301`	`QVariant value = attributevec[ fieldId[i] ];`
`1302`	`1302`
`1303`	`1303`	`QString v;`
`1304`		`- if ( !value.isValid() \|\| value.isNull() )`
	`1304`	`+ if ( value.isNull() )`
`1305`	`1305`	`{`
`1306`	`1306`	`if ( mPrimaryKeyAttrs.contains( i ) && !defaultValues.at( i ).isEmpty() )`
`1307`	`1307`	`{`