Skip to content
Permalink
Browse files

vector file writer: reapply integer options (accidentally removed in 9…

  • Loading branch information
jef-n committed Jul 13, 2017
1 parent a2b82bf commit fc7ac8323f80e245fc952521fc9a658ec4832824
Showing with 2 additions and 1 deletion.
  1. +2 −1 src/gui/ogr/qgsvectorlayersaveasdialog.cpp
@@ -744,7 +744,8 @@ QStringList QgsVectorLayerSaveAsDialog::layerOptions() const
QgsVectorFileWriter::IntOption *opt = dynamic_cast<QgsVectorFileWriter::IntOption *>( *it );
QSpinBox *sb = mLayerOptionsGroupBox->findChild<QSpinBox *>( it.key() );
if ( opt && sb && sb->value() != opt->defaultValue )
break;
options << QStringLiteral( "%1=%2" ).arg( it.key() ).arg( sb->value() );
break;
}

case QgsVectorFileWriter::Set:

6 comments on commit fc7ac83

@gioman

This comment has been minimized.

Copy link
Contributor

gioman replied Jul 24, 2017

@jef-n was this backported to 2.18?

@jef-n

This comment has been minimized.

Copy link
Member Author

jef-n replied Jul 24, 2017

No, 2.18 was not affected by this. See 9a6235d#commitcomment-23071479

@gioman

This comment has been minimized.

Copy link
Contributor

gioman replied Jul 24, 2017

No, 2.18 was not affected by this. See 9a6235d#commitcomment-23071479

sorry, 2.18.10/11 are very much affected by this.

@jef-n

This comment has been minimized.

Copy link
Member Author

jef-n replied Jul 24, 2017

As said the line re-added in this commit wasn't removed from 2.18 - so it can't possibly affect 2.18.

@gioman

This comment has been minimized.

Copy link
Contributor

gioman replied Jul 24, 2017

@jef ok ill try to be more precise: issues #16811 and #16819 were reported against 2.18.10 as regressions from 2.18.9 so this commit could not possibly close them, so they were reopened and the issues still affect 2.18.11

@jef-n

This comment has been minimized.

Copy link
Member Author

jef-n replied Jul 24, 2017

@gioman no need to get more precise here - and the comment referenced above already confirms that it's not a fix.

Please sign in to comment.
You can’t perform that action at this time.