Skip to content
Permalink
Browse files

Fix rasters cannot be styled on OSX (fix #13162)

Add missing Q_OBJECT macro

(cherry picked from commit 9b9dbff)
  • Loading branch information
nyalldawson authored and jef-n committed Aug 18, 2015
1 parent 8b734c8 commit fcdc609cc997b5e9794fa462731f5135654ede3a
Showing with 3 additions and 0 deletions.
  1. +1 −0 src/gui/CMakeLists.txt
  2. +2 −0 src/gui/raster/qgsrasterrendererwidget.h
@@ -353,6 +353,7 @@ SET(QGIS_GUI_MOC_HDRS
raster/qgssinglebandgrayrendererwidget.h
raster/qgssinglebandpseudocolorrendererwidget.h
raster/qgsrasterhistogramwidget.h
raster/qgsrasterrendererwidget.h

symbology-ng/characterwidget.h
symbology-ng/qgsbrushstylecombobox.h
@@ -27,6 +27,8 @@ class QgsRasterRenderer;

class GUI_EXPORT QgsRasterRendererWidget: public QWidget
{
Q_OBJECT

public:
QgsRasterRendererWidget( QgsRasterLayer* layer, const QgsRectangle &extent ):
mRasterLayer( layer )

8 comments on commit fcdc609

@anikabraun

This comment has been minimized.

Copy link

@anikabraun anikabraun replied Sep 10, 2015

Hi, thanks for this fix! I'm too stupid to apply it though. I modified the qgsrasterrenderwidget.h file but cannot find the CMakeLists.txt file...

@NathanW2

This comment has been minimized.

Copy link
Member

@NathanW2 NathanW2 replied Sep 10, 2015

@anikabraun you won't be able to patch your install with this unless you build from source or wait for a dev build.

@anikabraun

This comment has been minimized.

Copy link

@anikabraun anikabraun replied Sep 10, 2015

@NathanW2 Haha, ok good hint. Thanks. So I will go back to version 2.8 for raster displaying.

@Spartacus1

This comment has been minimized.

Copy link

@Spartacus1 Spartacus1 replied Sep 17, 2015

That's what I've done also - went back to version 2.8 for raster displaying. Strange how such a basic function was forgotten in MacOSX version 2.10. I'll be paying more attention in the future builds to try to give my contribution to detect these bugs into the MacOSX compilation

@nyalldawson

This comment has been minimized.

Copy link
Collaborator Author

@nyalldawson nyalldawson replied Sep 17, 2015

@Spartacus1 thanks, that's exactly what we need! More OSX users testing development builds and reporting bugs prior to releases.

@Spartacus1

This comment has been minimized.

Copy link

@Spartacus1 Spartacus1 replied Sep 17, 2015

It was a question of timing because 2.10 Pisa was released after the end of my GIS classes :)
I use the MacOSX version and many students also use it and this error would be easily detected.
In version 2.8, for instance, the most annoying bug was the Print Composer inability to plot coordinates outside the frame...
Thanks and keep on the outstanding work on making QGIS the best GIS tool!!

@Spartacus1

This comment has been minimized.

Copy link

@Spartacus1 Spartacus1 replied Sep 18, 2015

The problem still persists in the latest Night Build from Dakota Carto. Probably the fix is not working as expected.
Best Regards

@nyalldawson

This comment has been minimized.

Copy link
Collaborator Author

@nyalldawson nyalldawson replied Sep 18, 2015

@Spartacus1 @dakcarto's builds are broken. Look at the file date, they haven't been updated in months. I think you need to use homebrew and build from master yourself, but @dakcarto can probably confirm. (I'm not knowledgeable about OSX)

Please sign in to comment.
You can’t perform that action at this time.