Fix redoing group visibility creates multiple new undo commands

Author: nyalldawson

src/core/layout/qgslayoutitemgroup.cpp

@@ -115,10 +115,14 @@ void QgsLayoutItemGroup::setVisibility( const bool visible )
   {
     if ( !item )
       continue;
+    bool prev = item->mBlockUndoCommands;
+    item->mBlockUndoCommands = mBlockUndoCommands;
     item->setVisibility( visible );
+    item->mBlockUndoCommands = prev;
   }
   //lastly set visibility for group item itself
   QgsLayoutItem::setVisibility( visible );
+
   if ( !shouldBlockUndoCommands() )
     mLayout->undoStack()->endMacro();
 }

tests/src/core/testqgslayoutitemgroup.cpp

@@ -301,6 +301,23 @@ void TestQgsLayoutItemGroup::groupVisibility()
   QVERIFY( item->isVisible() );
   QVERIFY( item2->isVisible() );
   QVERIFY( group->isVisible() );
+
+  l.undoStack()->stack()->undo();
+  QVERIFY( !item->isVisible() );
+  QVERIFY( !item2->isVisible() );
+  QVERIFY( !group->isVisible() );
+  l.undoStack()->stack()->undo();
+  QVERIFY( item->isVisible() );
+  QVERIFY( item2->isVisible() );
+  QVERIFY( group->isVisible() );
+  l.undoStack()->stack()->redo();
+  QVERIFY( !item->isVisible() );
+  QVERIFY( !item2->isVisible() );
+  QVERIFY( !group->isVisible() );
+  l.undoStack()->stack()->redo();
+  QVERIFY( item->isVisible() );
+  QVERIFY( item2->isVisible() );
+  QVERIFY( group->isVisible() );
 }
 
 void TestQgsLayoutItemGroup::moveGroup()