Skip to content
Browse files

Merge pull request #39920 from rouault/wfs_translation

WFS provider: make layer tree view column headers translatable
  • Loading branch information
rouault committed Nov 10, 2020
2 parents c97d6d5 + 8a78f8f commit fe05aad7e1d71e7dae708ee43d8b5613e43df45d
Showing with 4 additions and 4 deletions.
  1. +4 −4 src/providers/wfs/qgswfssourceselect.cpp
@@ -97,10 +97,10 @@ QgsWFSSourceSelect::QgsWFSSourceSelect( QWidget *parent, Qt::WindowFlags fl, Qgs
mHoldDialogOpen->setChecked( settings.value( QStringLiteral( "Windows/WFSSourceSelect/HoldDialogOpen" ), false ).toBool() );

mModel = new QStandardItemModel();
mModel->setHorizontalHeaderItem( MODEL_IDX_TITLE, new QStandardItem( QStringLiteral( "Title" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_NAME, new QStandardItem( QStringLiteral( "Name" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_ABSTRACT, new QStandardItem( QStringLiteral( "Abstract" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_SQL, new QStandardItem( QStringLiteral( "Sql" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_TITLE, new QStandardItem( tr( "Title" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_NAME, new QStandardItem( tr( "Name" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_ABSTRACT, new QStandardItem( tr( "Abstract" ) ) );
mModel->setHorizontalHeaderItem( MODEL_IDX_SQL, new QStandardItem( tr( "Sql" ) ) );

mModelProxy = new QSortFilterProxyModel( this );
mModelProxy->setSourceModel( mModel );

2 comments on commit fe05aad


This comment has been minimized.

Copy link

@rduivenvoorde rduivenvoorde replied Nov 10, 2020

@rouault one of the little things that me bothered in this place is that the WMS is showing Name, Title and WFS is showing Title, Name.
Do you think it is wise to homogenize that (for other W*S dialogs? I think the human readable one (I always forget which one that is, probably Title should be first?


This comment has been minimized.

Copy link
Contributor Author

@rouault rouault replied Nov 10, 2020

Homogenization could be good. Title is supposed to be the human readable one

Please sign in to comment.
You can’t perform that action at this time.