Skip to content

Commit fe913a3

Browse files
committed
[Plugin Manager] better formatting of plugin details
1 parent 619558d commit fe913a3

File tree

1 file changed

+26
-13
lines changed

1 file changed

+26
-13
lines changed

src/app/pluginmanager/qgspluginmanager.cpp

Lines changed: 26 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -636,9 +636,15 @@ void QgsPluginManager::showPluginDetails( QStandardItem * item )
636636
html += QString( "<img src=\"%1\" style=\"float:right;\">" ).arg( metadata->value( "icon" ) );
637637
}
638638

639-
html += QString( "<h3>%2</h3><br/>" ).arg( metadata->value( "description" ) );
639+
html += QString( "<h3>%1</h3>" ).arg( metadata->value( "description" ) );
640640

641-
if ( ! metadata->value( "average_vote" ).isEmpty() )
641+
if ( ! metadata->value( "about" ).isEmpty() )
642+
{
643+
html += metadata->value( "about" );
644+
}
645+
646+
html += "<table><tr><td align='right' width='100%'>";
647+
if ( ! metadata->value( "average_vote" ).isEmpty() && metadata->value( "average_vote" ).toFloat() )
642648
{
643649
// draw stars
644650
int stars = qRound( metadata->value( "average_vote" ).toFloat() );
@@ -648,11 +654,16 @@ void QgsPluginManager::showPluginDetails( QStandardItem * item )
648654
}
649655
html += tr( "<br/>%1 rating vote(s)<br/>" ).arg( metadata->value( "rating_votes" ) );
650656
}
651-
if ( ! metadata->value( "downloads" ).isEmpty() )
657+
else if ( ! metadata->value( "downloads" ).isEmpty() )
652658
{
653-
html += tr( "%1 downloads<br/>" ).arg( metadata->value( "downloads" ) );
659+
// spacer between description and downloads
654660
html += "<br/>";
655661
}
662+
if ( ! metadata->value( "downloads" ).isEmpty() )
663+
{
664+
html += tr( "%1 downloads" ).arg( metadata->value( "downloads" ) );
665+
}
666+
html += "</td></tr></table><br/>";
656667

657668
if ( ! metadata->value( "category" ).isEmpty() )
658669
{
@@ -662,14 +673,6 @@ void QgsPluginManager::showPluginDetails( QStandardItem * item )
662673
{
663674
html += QString( "%1: %2 <br/>" ).arg( tr( "Tags" ) ).arg( metadata->value( "tags" ) );
664675
}
665-
if ( ! metadata->value( "author_email" ).isEmpty() )
666-
{
667-
html += QString( "%1: <a href='mailto:%2'>%3</a><br/>" ).arg( tr( "Author" ) ).arg( metadata->value( "author_email" ) ).arg( metadata->value( "author_name" ) );
668-
}
669-
else if ( ! metadata->value( "author_name" ).isEmpty() )
670-
{
671-
html += QString( "%1: %2<br/>" ).arg( tr( "Author" ) ).arg( metadata->value( "author_name" ) );
672-
}
673676
if ( ! metadata->value( "homepage" ).isEmpty() || ! metadata->value( "tracker" ).isEmpty() || ! metadata->value( "code_repository" ).isEmpty() )
674677
{
675678
html += QString( "%1: " ).arg( tr( "More info" ) );
@@ -687,9 +690,19 @@ void QgsPluginManager::showPluginDetails( QStandardItem * item )
687690
}
688691
html += "<br/>";
689692
}
690-
691693
html += "<br/>" ;
692694

695+
if ( ! metadata->value( "author_email" ).isEmpty() )
696+
{
697+
html += QString( "%1: <a href='mailto:%2'>%3</a>" ).arg( tr( "Author" ) ).arg( metadata->value( "author_email" ) ).arg( metadata->value( "author_name" ) );
698+
html += "<br/><br/>" ;
699+
}
700+
else if ( ! metadata->value( "author_name" ).isEmpty() )
701+
{
702+
html += QString( "%1: %2" ).arg( tr( "Author" ) ).arg( metadata->value( "author_name" ) );
703+
html += "<br/><br/>" ;
704+
}
705+
693706
if ( ! metadata->value( "version_installed" ).isEmpty() )
694707
{
695708
QString ver = metadata->value( "version_installed" );

0 commit comments

Comments
 (0)