Fix #10730 (fill ring does not work as expected)

wonder-sk · wonder-sk · commit fec9e65af554 · 2014-06-27T12:29:12.000+07:00
diff --git a/src/app/qgsmaptoolfillring.cpp b/src/app/qgsmaptoolfillring.cpp
@@ -168,10 +168,7 @@ void QgsMapToolFillRing::canvasReleaseEvent( QMouseEvent * e )
         {
           QgsAttributeDialog *dialog = new QgsAttributeDialog( vlayer, ft, false, NULL, true );
           dialog->setIsAddDialog( true );
-          if ( dialog->exec() )
-          {
-            res = vlayer->addFeature( *ft );
-          }
+          res = dialog->exec(); // will also add the feature
         }
 
         if ( res )

Original file line number	Diff line number	Diff line change
`@@ -168,10 +168,7 @@ void QgsMapToolFillRing::canvasReleaseEvent( QMouseEvent * e )`
`168`	`168`	`{`
`169`	`169`	`QgsAttributeDialog *dialog = new QgsAttributeDialog( vlayer, ft, false, NULL, true );`
`170`	`170`	`dialog->setIsAddDialog( true );`
`171`		`- if ( dialog->exec() )`
`172`		`- {`
`173`		`- res = vlayer->addFeature( *ft );`
`174`		`- }`
	`171`	`+ res = dialog->exec(); // will also add the feature`
`175`	`172`	`}`
`176`	`173`
`177`	`174`	`if ( res )`