Permalink
Switch branches/tags
Commits on May 23, 2016
Commits on Apr 29, 2016
  1. Release of 2.8.9

    jef-n committed Apr 29, 2016
Commits on Apr 27, 2016
  1. Remove conversions.sip conditionals meant for 4.12 but actually 4.18

    dakcarto committed Apr 16, 2016
    - The hex version of 4.12 was not 0x041200 (current 4.18) but 0x040c00.
      Code was always skipped and has worked with recent sip versions.
    
    (cherry-picked from commit fc6559a)
Commits on Apr 25, 2016
  1. osgeo4w: add qt plugin directories to browser

    jef-n committed Apr 25, 2016
    (cherry picked from commit b758a8c)
Commits on Apr 9, 2016
  1. Fix thread-unsafe initialization of QgsExpression::Functions()

    rouault authored and m-kuhn committed Apr 8, 2016
    The method initializes the gmFunctions static member, without any mutex protection.
    This turned out to cause random crashes in the tests of the WFS provider since the downloader
    thread may evaluate an expression, in parallel of the main thread, which does the same.
    This was mainly seen on Mac Travis (2 crashes + 1 failures, over 50 iterations), when
    parallelizing tests so as to get particular scheduling :
    https://travis-ci.org/rouault/Quantum-GIS/builds/121720556.
    But I could finally reproduce it systematically on my Linux box when inserting the following sleep.
    
    diff --git a/src/providers/wfs/qgswfsshareddata.cpp b/src/providers/wfs/qgswfsshareddata.cpp
    index adc7042..e9e4577 100644
    --- a/src/providers/wfs/qgswfsshareddata.cpp
    +++ b/src/providers/wfs/qgswfsshareddata.cpp
    @@ -426,6 +426,7 @@ int QgsWFSSharedData::registerToCache( QgsWFSFeatureIterator* iterator, QgsRecta
         connect( mDownloader, SIGNAL( ready() ), &loop, SLOT( quit() ) );
         mDownloader->start();
         loop.exec( QEventLoop::ExcludeUserInputEvents );
    +    usleep( 100 * 1000 );
       }
       if ( mDownloadFinished )
         return -1;
    
    After applying this commit, the Mac builder is fine:
    https://travis-ci.org/rouault/Quantum-GIS/builds/121756158
Commits on Apr 8, 2016
  1. [BUGFIX] QGIS Server segfault when features does not have the same fi…

    rldhont committed Apr 8, 2016
    …elds as the layer.
    
    In some WFS GetFeature request, with Filter or FeatureId, all the fields are not well loaded in the feature.
    
    To fix it, we just verifying that the attribute index is lesser than the feature fields count.
    
    Fixes #14619
Commits on Apr 5, 2016
  1. globe plugin: fix crash on exit

    jef-n committed Mar 31, 2016
    (cherry picked from commit bde5126)
Commits on Mar 25, 2016
  1. Release of 2.8.8

    jef-n committed Mar 25, 2016
  2. [Spatialite] Fix crash on iterator closing if connection failed.

    rouault authored and jef-n committed Mar 24, 2016
    If an iterator fails to open the spatialite database (mHandle == nullptr
    in QgsSpatiaLiteFeatureIterator::QgsSpatiaLiteFeatureIterator() ),
    a crash will occur at the destruction of the QgsSpatiaLiteFeatureSource,
    due to the iterator not being removed from the list of active iterators.
    
    Currently QgsSpatiaLiteFeatureIterator::close() does not call
    iteratorClosed() if mHandle is invalid, which later causes
    QgsAbstractFeatureSource::~QgsAbstractFeatureSource() to try calling
    the close() method of a now defunct iterator.
    
    If not applying the patch, the added test case crashes with:
    
    177: src/providers/spatialite/qgsspatialiteconnection.cpp: 736: (openDb) [1ms] New sqlite connection for /tmp/test.sqlite.corrupt
    177: src/providers/spatialite/qgsspatialiteconnection.cpp: 750: (openDb) [1ms] Failure while connecting to: /tmp/test.sqlite.corrupt
    177:
    177: invalid metadata tables
    177: src/core/qgsfeaturerequest.cpp: 259: (~QgsAbstractFeatureSource) [0ms] closing active iterator
    177: CMake Error at PyQgsSpatialiteProvider.cmake:22 (MESSAGE):
    177:   Test failed: Segmentation fault
    (cherry picked from commit 2b15eaa)
Commits on Mar 24, 2016
  1. Use consistant default value of 60000ms for /qgis/networkAndProxy/net…

    rouault authored and jef-n committed Mar 24, 2016
    …workTimeout
    
    Currently there's an inconsistancy between the Options dialog that displays a
    default value of 60000ms for network request timeouts, whereas places in the
    code use 20000ms. I propose to align on 60000s, since there are occurrences
    of network requests, for example big WFS GetFeature requests, that can take
    more than 20s to start.
    
    (testqgswcspublicservers.cpp update added)
    
    (cherry picked from commit 2f7d4a7)
Commits on Mar 23, 2016
  1. [Spatialite] Use correct free function for sqlite3_bind_blob of geome…

    rouault authored and jef-n committed Mar 23, 2016
    …tries
    
    Currently sqlite3_bind_blob() uses free() as the free function of WKB
    blobs returned by convertFromGeosWKB(). But those are allocated with
    new[] and should consequently be freed with delete[].
    
    Spotted by Valgrind:
    ==4014== Mismatched free() / delete / delete []
    ==4014==    at 0x4C287BE: free (vg_replace_malloc.c:446)
    ==4014==    by 0xE42E481: sqlite3VdbeMemReleaseExternal (sqlite3.c:57237)
    ==4014==    by 0xE42E4E3: sqlite3VdbeMemRelease (sqlite3.c:57252)
    ==4014==    by 0xE42EC3E: releaseMemArray (sqlite3.c:59208)
    ==4014==    by 0xE42ED1E: sqlite3VdbeDeleteObject (sqlite3.c:60561)
    ==4014==    by 0xE46A6DB: sqlite3VdbeFinalize (sqlite3.c:60528)
    ==4014==    by 0xE46A916: sqlite3_finalize (sqlite3.c:61431)
    ==4014==    by 0x7FB23958: QgsSpatiaLiteProvider::addFeatures(QList<QgsFeature>&) (qgsspatialiteprovider.cpp:3752)
    ==4014==  Address 0x8e2a8b30 is 0 bytes inside a block of size 94 alloc'd
    ==4014==    at 0x4C29520: operator new[](unsigned long) (vg_replace_malloc.c:363)
    ==4014==    by 0x7FB1B964: QgsSpatiaLiteProvider::convertFromGeosWKB(unsigned char const*, int, unsigned char**, int*, int) (qgsspatialiteprovider.cpp:1341)
    ==4014==    by 0x7FB234B5: QgsSpatiaLiteProvider::addFeatures(QList<QgsFeature>&) (qgsspatialiteprovider.cpp:3676)
    
    (cherry picked from commit 2e04162)
Commits on Mar 22, 2016
  1. crssync: skip more crses that cannot be copied

    jef-n committed Mar 19, 2016
    (cherry picked from commit 71429be)
  2. Add internal qwtpolar 1.1.1 for Qwt 6.1

    jef-n committed Mar 15, 2016
    (cherry picked from commit c3881d4)
Commits on Mar 13, 2016
  1. globe: adapt to osgearth 2.7

    jef-n committed Mar 8, 2016
    (cherry picked from commit 342a754)
Commits on Mar 9, 2016
  1. [BUGFIX][QGIS Server] To avoid infinite loop in layer creation

    rldhont committed Mar 9, 2016
    Insert layer in registry and cache before addValueRelationLayersForLayer
Commits on Feb 26, 2016
  1. Release of 2.8.7

    jef-n committed Feb 26, 2016
  2. german translation update

    jef-n committed Feb 26, 2016
Commits on Feb 25, 2016
  1. [BUGFIX][Processing] Reset SAGA InverseDistanceWeighted algorithm

    rldhont committed Feb 25, 2016
    Reset 2 parameters :
    * SEARCH_POINTS_ALL
    * SEARCH_POINTS_MAX
    
    These parameters was defined in 2.1.2 but are available in the next version :
    http://www.saga-gis.org/saga_module_doc/2.1.3/grid_gridding_1.html
Commits on Feb 24, 2016
  1. [BUGFIX] Extend WFS field type description (time)

    rldhont committed Feb 24, 2016
    Continue commit 2ad32f1
Commits on Feb 23, 2016
  1. Use QgsFields::fieldNameIndex when preparing column refs in expressions

    nyalldawson committed Feb 23, 2016
    Fixes handling of duplicate field names with different case in
    expressions
    
    (cherry-picked from 0a84fbd)
  2. Remove unused help button from style manager (fix #14055)

    nyalldawson committed Feb 23, 2016
    (cherry-picked from 17ed9d1)
  3. Fix raster layers not rendering on Windows 8

    nyalldawson committed Feb 23, 2016
    The copy constructor for QgsContrastEnhancement was using
    an uninitialized value for the mContrastEnhancementAlgorithm
    member, resulting in no contrast function being set in
    certain occasions.
    
    Refs #13155
    
    (cherry-picked from cc50542)
  4. Fix categorised renderer does not store changes to the source symbol

    nyalldawson committed Feb 23, 2016
    Avoids the frustrating situation where changes to a symbol in the
    categorised renderer are lost when the layer properties window
    is reopened
    
    Also fix a leak in the Python bindings
    
    (cherry-picked from 3744ac2)
  5. Increase maximum size of diagram spinbox (fix #14282)

    nyalldawson committed Feb 23, 2016
    (cherry-picked from 087e148)
Commits on Feb 9, 2016
  1. [BUGFIX][QGIS Server] WFS Service Capability OnlineResource

    rldhont committed Feb 9, 2016
    WFS Service Capability OnlineResource is not the same as in WMS.
Commits on Jan 23, 2016
  1. fix arm build

    jef-n committed Mar 9, 2015
    (cherry picked from commit 1aff733)
  2. merge debian downstream patches

    jef-n committed Jan 21, 2016
Commits on Jan 19, 2016
  1. [bugfix][DbManager] 14110 - Error fetching layer indexes with recent …

    mdouchin authored and rldhont committed Jan 19, 2016
    …sqlite version
    
    Fixes #14110
    
    The method `getTableIndexes`, situated in line 371 of the file `db_manager/db_plugins/spatialite/connector.py`,
    expected to get 3 fields from the sqlite method `PRAGMA index_list` .
    In recent versions of SQLite, since 3.8.9, though, this method now returns 5 fields.
    This commit fixes this issue by checking the length of columns returned by the method.