5 changes: 1 addition & 4 deletions src/providers/osm/osmhandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -98,20 +98,17 @@ OsmHandler::~OsmHandler()
sqlite3_finalize( mStmtInsertVersion );
}


bool OsmHandler::startDocument()
{
sqlite3_exec( mDatabase, "BEGIN;", 0, 0, 0 );
return true;
}


QString OsmHandler::errorString()
QString OsmHandler::errorString() const
{
return mError;
}


bool OsmHandler::startElement( const QString & pUri, const QString & pLocalName, const QString & pName, const QXmlAttributes & pAttrs )
{
Q_UNUSED( pUri );
Expand Down
2 changes: 1 addition & 1 deletion src/providers/osm/osmhandler.h
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class OsmHandler: public QXmlDefaultHandler
* Returns information on error that occures while parsing.
* @return info on error that occures while parsing
*/
QString errorString();
QString errorString() const;

public:
int mPointCnt;
Expand Down
4 changes: 1 addition & 3 deletions src/providers/postgres/qgspostgresprovider.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -750,15 +750,13 @@ void QgsPostgresProvider::appendPkParams( QgsFeatureId featureId, QStringList &p

for ( int i = 0; i < mPrimaryKeyAttrs.size(); i++ )
{
int idx = mPrimaryKeyAttrs[i];

if ( i < pkVals.size() )
{
params << pkVals[i].toString();
}
else
{
QgsDebugMsg( QString( "FAILURE: Key value %1 for feature %2 not found." ).arg( idx ).arg( featureId ) );
QgsDebugMsg( QString( "FAILURE: Key value %1 for feature %2 not found." ).arg( mPrimaryKeyAttrs[i] ).arg( featureId ) );
params << "NULL";
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/providers/sqlanywhere/qgssqlanywhereprovider.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ QgsSqlAnywhereProvider::subsetString()
} // QgsSqlAnywhereProvider::subsetString()

bool
QgsSqlAnywhereProvider::setSubsetString( QString theSQL )
QgsSqlAnywhereProvider::setSubsetString( QString theSQL, bool )
{
QString prevSubsetString = mSubsetString;
QString prevKeyColumn = mKeyColumn;
Expand Down
2 changes: 1 addition & 1 deletion src/providers/sqlanywhere/qgssqlanywhereprovider.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class QgsSqlAnywhereProvider: public QgsVectorDataProvider
virtual QString subsetString();

/** mutator for sql where clause used to limit dataset size */
virtual bool setSubsetString( QString theSQL );
virtual bool setSubsetString( QString theSQL, bool updateFeatureCount = true );
virtual bool supportsSubsetString() { return true; }

/** Select features based on a bounding rectangle. Features can be retrieved with calls to nextFeature.
Expand Down
11 changes: 6 additions & 5 deletions src/providers/wfs/qgswfsprovider.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ static const QString GML_NAMESPACE = "http://www.opengis.net/gml";
QgsWFSProvider::QgsWFSProvider( const QString& uri )
: QgsVectorDataProvider( uri ),
mNetworkRequestFinished( true ),
mEncoding( QgsWFSProvider::GET ),
mRequestEncoding( QgsWFSProvider::GET ),
mUseIntersect( false ),
mWKBType( QGis::WKBUnknown ),
mSourceCRS( 0 ),
Expand All @@ -69,11 +69,11 @@ QgsWFSProvider::QgsWFSProvider( const QString& uri )
//Local url or HTTP? [WBC 111221] refactored from getFeature()
if ( uri.startsWith( "http" ) )
{
mEncoding = QgsWFSProvider::GET;
mRequestEncoding = QgsWFSProvider::GET;
}
else
{
mEncoding = QgsWFSProvider::FILE;
mRequestEncoding = QgsWFSProvider::FILE;
}

//create mSourceCRS from url if possible [WBC 111221] refactored from GetFeatureGET()
Expand Down Expand Up @@ -346,7 +346,7 @@ void QgsWFSProvider::select( QgsAttributeList fetchAttributes,

int QgsWFSProvider::getFeature( const QString& uri )
{
if ( mEncoding == QgsWFSProvider::GET )
if ( mRequestEncoding == QgsWFSProvider::GET )
{
return getFeatureGET( uri, mGeometryAttribute );
}
Expand Down Expand Up @@ -721,7 +721,7 @@ int QgsWFSProvider::describeFeatureType( const QString& uri, QString& geometryAt
{
fields.clear();
//Local url or HTTP? WBC111221 refactored here from getFeature()
switch ( mEncoding )
switch ( mRequestEncoding )
{
case QgsWFSProvider::GET:
{
Expand Down Expand Up @@ -2382,6 +2382,7 @@ bool QgsWFSProvider::initGetRenderedOnly( const QgsRectangle rect )

QGis::WkbType QgsWFSProvider::geomTypeFromPropertyType( QString attName, QString propType )
{
Q_UNUSED( attName );
const QStringList geomTypes = ( QStringList()
//all GML v.2.1.3 _geometryProperty group members, except MultiGeometryPropertyType
//sequence must exactly match enum Qgis::WkbType
Expand Down
6 changes: 3 additions & 3 deletions src/providers/wfs/qgswfsprovider.h
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ class QgsWFSProvider: public QgsVectorDataProvider
/* new functions */

/**Sets the encoding type in which the provider makes requests and interprets
results. Posibilities are GET, POST, SOAP*/
void setEncoding( QgsWFSProvider::REQUEST_ENCODING e ) {mEncoding = e;}
results. Possibilities are GET, POST, SOAP*/
void setRequestEncoding( QgsWFSProvider::REQUEST_ENCODING e ) {mRequestEncoding = e;}

/**Makes a GetFeatures, receives the features from the wfs server (as GML), converts them to QgsFeature and
stores them in a vector*/
Expand Down Expand Up @@ -166,7 +166,7 @@ class QgsWFSProvider: public QgsVectorDataProvider
/**Name of geometry attribute*/
QString mGeometryAttribute;
/**The encoding used for request/response. Can be GET, POST or SOAP*/
REQUEST_ENCODING mEncoding;
REQUEST_ENCODING mRequestEncoding;
/**Bounding box for the layer*/
QgsRectangle mExtent;
/**Spatial filter for the layer*/
Expand Down
4 changes: 2 additions & 2 deletions src/providers/wms/qgswmsprovider.h
Original file line number Diff line number Diff line change
Expand Up @@ -422,12 +422,12 @@ class QgsWmsProvider : public QgsRasterDataProvider
* (in order from bottom to top)
* \note layers must have been previously added.
*/
void setLayerOrder( QStringList const & layers );
virtual void setLayerOrder( QStringList const & layers );

/**
* Set the visibility of the given sublayer name
*/
void setSubLayerVisibility( QString const & name, bool vis );
virtual void setSubLayerVisibility( const QString &name, bool vis );

/**
* Get the image encoding (as a MIME type) used in the transfer from the WMS server
Expand Down