Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Expression] point_n function should be coherent with other vertex based functions and algorithms #29100

Open
qgib opened this issue Feb 15, 2019 · 7 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Expressions Related to the QGIS expression engine or specific expression functions

Comments

@qgib
Copy link
Contributor

qgib commented Feb 15, 2019

Author Name: Harrissou Santanna (@DelazJ)
Original Redmine Issue: 21282
Affected QGIS version: 3.7(master)
Redmine category:expressions


I don't know if I should report it as a bug or a feature request...

The point_n function returns a specific node on a geometry, based on the provided index. The first vertex index is 1.
But when using Processing to extract vertices from a feature, the vertex_index is 0-based. Some other expression that manipulates vertices (angle_at_vertex, distance_to_vertex) are also 0-based.
It could be nice to align the point_n function with the others.


Related issue(s): #29102 (relates)
Redmine related issue(s): 21284


@qgib
Copy link
Contributor Author

qgib commented Feb 15, 2019

@qgib
Copy link
Contributor Author

qgib commented Mar 13, 2019

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)


IMHO, it's an inconsistency which should be considered as a bug. Fixing this will have to wait until we cross the QGIS 4.0 bridge.


  • regression was configured as 0
  • crashes_corrupts_data was configured as 0
  • version was configured as 3.7(master)
  • tracker_id was changed from 2 to 1

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Expressions Related to the QGIS expression engine or specific expression functions labels May 25, 2019
@Pedro-Murteira
Copy link

@DelazJ Hello, is this issue still valid on recent releases?

@Pedro-Murteira Pedro-Murteira added the Feedback Waiting on the submitter for answers label May 2, 2022
@github-actions
Copy link

The QGIS project highly values your report and would love to see it addressed. However, this issue has been left in feedback mode for the last 14 days and is being automatically marked as "stale".
If you would like to continue with this issue, please provide any missing information or answer any open questions. If you could resolve the issue yourself meanwhile, please leave a note for future readers with the same problem and close the issue.
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this issue.
If there is no further activity on this issue, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 17, 2022
@github-actions
Copy link

While we hate to see this happen, this issue has been automatically closed because it has not had any activity in the last 42 days despite being marked as feedback. If this issue should be reconsidered, please follow the guidelines in the previous comment and reopen this issue.
Or, if you have any further questions, there are also further support channels that can help you.

@DelazJ
Copy link
Contributor

DelazJ commented Jun 14, 2022

Still an issue and according to @nirvn comment above it has to wait for 4.0. So unless it has been reported on a 4.0 breaking changes repository, it shouldn't be closed.

@DelazJ DelazJ reopened this Jun 14, 2022
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 14, 2022
@DelazJ DelazJ removed the Feedback Waiting on the submitter for answers label Jun 14, 2022
@Koyaani
Copy link
Contributor

Koyaani commented Nov 10, 2022

geometry_n and interior_ring_n are not really vertex based functions, but their index start from 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Expressions Related to the QGIS expression engine or specific expression functions
Projects
None yet
Development

No branches or pull requests

4 participants