Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference geoprocessing fails because of GEOS #39029

Closed
arx-it opened this issue Sep 25, 2020 · 11 comments
Closed

Difference geoprocessing fails because of GEOS #39029

arx-it opened this issue Sep 25, 2020 · 11 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms Upstream Needs changes in an upstream library (like Qt, Proj, GDAL, ...)

Comments

@arx-it
Copy link

arx-it commented Sep 25, 2020

I have a problem with geopackages datas (polygons) : With the "difference" geoprocessing

Here are the data : https://drive.google.com/drive/folders/1jseoFHmzw5r_yQoxSywuPBHZkYctdx63?usp=sharing

I have also reply to this bug report : #29400

Here is the log :

Version de QGIS : 3.14.1-Pi
Révision du code : de08d6b
Version de Qt : 5.11.2
Version de GDAL : 3.0.4
Version de GEOS : 3.8.1-CAPI-1.13.3
Version de Proj : Rel. 6.3.2, May 1st, 2020
Traitement de l'algorithme…
Démarrage de l'algorithme 'Différence'…
Paramètres en entrée:
{ 'INPUT' : 'D:/Temp/qgis_crash/grand.gpkg|layername=grand', 'OUTPUT' : 'TEMPORARY_OUTPUT', 'OVERLAY' : 'D:/Temp/qgis_crash/petit.gpkg|layername=petit' }

Erreur de géotraitement GEOS: la différence a échoué.

Échec d'exécution au bout de 0.15 secondes

Chargement des couches de résultat
Algorithme 'Différence' terminé

Thank you in advance.

@arx-it arx-it added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Sep 25, 2020
@gioman gioman added the Processing Relating to QGIS Processing framework or individual Processing algorithms label Sep 25, 2020
@roya0045
Copy link
Contributor

Are they in the same projection?

@gioman
Copy link
Contributor

gioman commented Sep 26, 2020

Are they in the same projection?

@roya0045 they are.

The operation fails with QGIS native tool, also after running the "fix geometries" tool on the inputs. GRASS and SAGA tools process the data correctly. Maybe this type of problem will be solved when we will, start to use the next gen of GEOS, the one including the improvements about rounding and snapping?

@gioman
Copy link
Contributor

gioman commented Sep 26, 2020

Closing as upstream issue?

@strk
Copy link
Contributor

strk commented Sep 28, 2020

Was upstream ticket filed ?

@gioman
Copy link
Contributor

gioman commented Sep 28, 2020

Was upstream ticket filed ?

@strk I don't follow the GEOS tracker.

@strk
Copy link
Contributor

strk commented Sep 28, 2020

The bug is confirmed with GEOS-3.9.0dev:

strk=# select ST_Summary(ST_Difference(g.geom, p.geom)) from grand g, petit p;
ERROR:  lwgeom_difference_prec: GEOS Error: TopologyException: found non-noded intersection between LINESTRING (655065 1.79482e+06, 655065 1.79482e+06) and LINESTRING (655065 1.79482e+06, 655065 1.79482e+06) at 655065.0840699079 1794820.6249905184
strk=# select postgis_full_version();
                                                                                                                                                               postgis_full_version                                                                                                                                                               
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 POSTGIS="3.1.0dev 3.1.0alpha2-69-gf50dcaaaa" [EXTENSION] PGSQL="120" GEOS="3.9.0dev-CAPI-1.14.0" PROJ="6.3.1" LIBXML="2.9.10" LIBJSON="0.13.1" LIBPROTOBUF="1.3.3" WAGYU="0.5.0 (Internal)" (core procs from "3.1.0dev 3.1.0alpha2-63-g801577ae4" need upgrade) TOPOLOGY (topology procs from "3.1.0dev 3.1.0alpha2-64-g7e692d0f2" need upgrade)
(1 row)

RE following GEOS tracker, what's the policy about upstream issues ? I'd say before closing a ticket here a link to an upstream ticket should be filed ?

@strk
Copy link
Contributor

strk commented Sep 28, 2020

I've filed https://trac.osgeo.org/geos/ticket/1051 for OverlayNG results

@gioman
Copy link
Contributor

gioman commented Sep 28, 2020

'd say before closing a ticket here a link to an upstream ticket should be filed ?

yes,

thanks for the upstream ticket.

@gioman gioman closed this as completed Sep 28, 2020
@gioman gioman added the Upstream Needs changes in an upstream library (like Qt, Proj, GDAL, ...) label Sep 28, 2020
@arx-it
Copy link
Author

arx-it commented Sep 28, 2020

Thank you for your replies.
Ok for GRASS and SAGA tools !

@strk
Copy link
Contributor

strk commented Sep 28, 2020

for the record: this is now fixed in GEOS master (to be released as 3.9.0)

@arx-it
Copy link
Author

arx-it commented Sep 30, 2020

Ok thank you, we will wait QGIS next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms Upstream Needs changes in an upstream library (like Qt, Proj, GDAL, ...)
Projects
None yet
Development

No branches or pull requests

4 participants